From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B5341C61DD3 for ; Tue, 1 Sep 2026 17:24:22 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x1SDU-00014l-Tn; Tue, 01 Sep 2026 13:24:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x1SDS-00014J-QS for qemu-devel@nongnu.org; Tue, 01 Sep 2026 13:24:10 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x1SDR-0005ns-8J for qemu-devel@nongnu.org; Tue, 01 Sep 2026 13:24:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788283448; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TrrXtH4QF84jbERASytexUQg9adqtz/Wio6yLSLjSOU=; b=SKlwwHVOyJ2x79rykzYXFjoLCx1+4mP8OeTPFl3ltS7SbVqOz2x6kk+cO6Sd1P+bQ5HhbS CzcKKvvkdjDNh07vHv1xwGmVJiQfj6PtnNJxe/BO+ukA8VwXUhsYAygswaiOX8Q5xBo0EF p4sgpyuY5/AKnXe56mezSsc8vnQ9GNQ= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-128-boUmGFbJOY63B8517Lf9fQ-1; Tue, 01 Sept 2026 13:24:07 -0400 X-MC-Unique: boUmGFbJOY63B8517Lf9fQ-1 X-Mimecast-MFC-AGG-ID: boUmGFbJOY63B8517Lf9fQ_1788283446 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AAC5F19540D0; Tue, 1 Sep 2026 17:24:05 +0000 (UTC) Received: from redhat.com (headnet05.pony-001.prod.iad2.dc.redhat.com [10.2.32.117]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 40B0C18005B7; Tue, 1 Sep 2026 17:24:04 +0000 (UTC) Date: Tue, 1 Sep 2026 18:24:01 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: "Denis V. Lunev" Cc: qemu-devel@nongnu.org, qemu-stable@nongnu.org, =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Subject: Re: [PATCH 3/6] io/channel-websock: handle a blocked write during the handshake Message-ID: References: <20260831100151.914178-1-den@openvz.org> <20260831100151.914178-4-den@openvz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260831100151.914178-4-den@openvz.org> User-Agent: Mutt/2.4.0 (2026-06-19) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, Aug 31, 2026 at 12:01:48PM +0200, Denis V. Lunev wrote: > From: Denis V. Lunev > > qio_channel_websock_handshake_send() treats every negative return from > qio_channel_write() as fatal and passes err to error_get_pretty(). > QIO_CHANNEL_ERR_BLOCK is negative but leaves err NULL, so a socket > which cannot take the response immediately crashes QEMU before the > client has authenticated. > > Keep the G_IO_OUT watch armed and retry instead. > > Fixes: 2d1d0e70cf3e ("io: add QIOChannelWebsock class") > Cc: qemu-stable@nongnu.org > Cc: Daniel P. Berrangé > Cc: Marc-André Lureau > Signed-off-by: Denis V. Lunev > --- > io/channel-websock.c | 5 +++++ > 1 file changed, 5 insertions(+) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|