From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DAAFF4A13B0; Tue, 1 Sep 2026 18:51:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788288717; cv=none; b=mUEkt9LR760mkfe+3S8rGRv/ujmSelrdBO18o7dCbrZqXxl0ZEpGUfAU2CFtZzPLnEopon+FvuBPP8q87Az+av7hwJ5JTPcEBtPL0Btv5z8RZfl1E/e6jzMEhCI4dcGuY4jBYb5XD2KAxlpxEbd/V4svnqOQ39gL6s6zWviUtjQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788288717; c=relaxed/simple; bh=N2sreEKsDcVI84Eu5n2UeUAeL3ybecKJOOqlNYIxixA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QYsf3wJXIG5CunN+/TXcj6mWu4FcoLQeaw/S0fJTLn7WJOGKB7MXesOiNFDhVrwismeYgXjR+BJ5bUdmG11ghC5xsdTU6JBlDj6EICAj2+Wj7pnv444BcUWG8OXRCYGOKSDZL0RoLq2yKzK5O+oSeT3RwiQ/qmZUmoor4BzNte0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gvy3hK2+; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gvy3hK2+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3005B1F00A3E; Tue, 1 Sep 2026 18:51:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788288714; bh=DTElpTF2Qn/IaBTa9jxhtkZ5uzOwfG9EJYNuwd/znTA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=gvy3hK2+4VwA8xWxUJnLCFolVKknSpywUJuPwq3DwufQTyePpWEUz+NacHISS8R3H Cn3QVcVjDk0alKhMtuJwPAVTziMaX3gWBIjwheccHCkhUTvc5Y1hebQEtHvJUR3rOh 2/aTJPMOw3t6YKKJI+OyfDxnBkiQX/nPOrMztiXWWdaThjB+n0i0xo6ctaCTZ4v1yD wdDG6Z7cZQ7qnKFvHR1Vn39OxXNl9faMkk5Od+iUGo47kRd8cki7vctKGKjVoiugF4 egymNTSWd4H49ToeYHqnlw1P9LJO9i80+9IKl5atvXvrmzA0fHSCPPJNdz5a/R7hnb +/hk+fV9+/fMQ== Date: Wed, 2 Sep 2026 02:51:48 +0800 From: Zorro Lang To: Anand Jain Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, djwong@kernel.org Subject: Re: [PATCH v8 08/13] fstests: verify f_fsid for cloned filesystems Message-ID: Mail-Followup-To: Anand Jain , fstests@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, djwong@kernel.org References: Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sat, Jul 25, 2026 at 03:39:05PM +0800, Anand Jain wrote: > Verify that the cloned filesystem provides an f_fsid that is persistent > across mount cycles, yet unique from the original filesystem's f_fsid. > > Signed-off-by: Anand Jain > --- > tests/generic/802 | 64 +++++++++++++++++++++++++++++++++++++++++++ > tests/generic/802.out | 4 +++ > 2 files changed, 68 insertions(+) > create mode 100644 tests/generic/802 > create mode 100644 tests/generic/802.out > > diff --git a/tests/generic/802 b/tests/generic/802 > new file mode 100644 > index 000000000000..910807c11584 > --- /dev/null > +++ b/tests/generic/802 > @@ -0,0 +1,64 @@ > +#! /bin/bash > +# SPDX-License-Identifier: GPL-2.0 > +# Copyright (c) 2026 Anand Jain . All Rights Reserved. > +# > +# FS QA Test 802 > +# Check that the cloned filesystem provides an f_fsid that is persistent > +# across mount cycles if the block device maj:min remains unchanged. > + > +. ./common/preamble > + > +_begin_fstest auto quick mount clone > + > +_require_test > +_require_block_device $TEST_DEV > +_require_loop > + > +_fixed_by_fs_commit btrfs xxxxxxxxxxxx \ > + "btrfs: use on-disk uuid for s_uuid in temp_fsid mounts" > +_fixed_by_fs_commit btrfs xxxxxxxxxxxx \ > + "btrfs: derive f_fsid from on-disk fsuuid and dev_t" > + > +_cleanup() > +{ > + cd / > + rm -r -f $tmp.* > + umount $mnt1 $mnt2 2>/dev/null > + _loop_image_destroy "${devs[@]}" 2> /dev/null > +} > + > +# Setup base loop device and its clone > +devs=() > +_loop_image_create_clone devs > +mkdir -p $TEST_DIR/$seq Better to `rm -rf $TEST_DIR/$seq` before creating a new one. > +mnt1=$TEST_DIR/$seq/mnt1 > +mnt2=$TEST_DIR/$seq/mnt2 > +mkdir -p $mnt1 > +mkdir -p $mnt2 > + > +# Mount both filesystems simultaneously using mandatory clone mount options > +_mount $(_common_dev_mount_options) $(_clone_mount_option) ${devs[0]} $mnt1 || \ > + _fail "Failed to mount dev1" > +_mount $(_common_dev_mount_options) $(_clone_mount_option) ${devs[1]} $mnt2 || \ > + _fail "Failed to mount dev2" > + > +# Capture baseline filesystem IDs for comparison > +fsid_scratch=$(stat -f -c "%i" $mnt1) > +fsid_clone=$(stat -f -c "%i" $mnt2) > + > +# Verify that the fsids remain stable after a mount cycle, even when the > +# mount order is reversed. > +echo "**** fsid after mount cycle ****" > +_unmount $mnt1 > +_unmount $mnt2 > +_mount $(_common_dev_mount_options) $(_clone_mount_option) ${devs[1]} $mnt2 || \ > + _fail "Failed to mount dev2" > +_mount $(_common_dev_mount_options) $(_clone_mount_option) ${devs[0]} $mnt1 || \ > + _fail "Failed to mount dev1" > + > +# Compare post mount-cycle values against the baseline > +stat -f -c "%i" $mnt1 | sed -e "s/$fsid_scratch/FSID_SCRATCH/g" > +stat -f -c "%i" $mnt2 | sed -e "s/$fsid_clone/FSID_CLONE/g" Hmm... what if "$fsid_scratch" is same with "$fsid_clone"? > + > +status=0 > +exit _exit 0 > diff --git a/tests/generic/802.out b/tests/generic/802.out > new file mode 100644 > index 000000000000..0202a9a2c108 > --- /dev/null > +++ b/tests/generic/802.out > @@ -0,0 +1,4 @@ > +QA output created by 802 > +**** fsid after mount cycle **** > +FSID_SCRATCH > +FSID_CLONE > -- > 2.43.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BAC15C624D3 for ; Tue, 1 Sep 2026 18:52:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:In-Reply-To:MIME-Version:References: Message-ID:To:Date:Sender:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uOsDIOQQVgAVlQsErekkHYPMEV8PitGp2jZs5wmUgoU=; b=P81KV7hqRxUxg070lerQhOi2W9 Jip1LD5ps2472BPPA/AaHyPenNZbxq0v4IKi1mr1F02+k27XE137pl1oof1gyZTNSbl0msKFFgHZj 73ARUhgzjjujYE6Wzi/nwyovCrsdUaOGsADvqOm+NAaLlQAulCXP9v0jgxAoeScpyWuU=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1x1TaV-00065m-Py; Tue, 01 Sep 2026 18:52:04 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1x1TaU-00065g-Bu for linux-f2fs-devel@lists.sourceforge.net; Tue, 01 Sep 2026 18:52:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=DTElpTF2Qn/IaBTa9jxhtkZ5uzOwfG9EJYNuwd/znTA=; b=da6k5slAEpUIMpYqfizvfNORR0 ybQtEhHpTP3H6A22m2BCdzQWhzIIb7EjKhmJFGdGxdaV7ivxKQvtmAs1dPFr6m8wT4dnEhtJZWz8l RioreHeoqCV0W3ACbdPgVf4qoSS7xJG8l5BhCSnyn405lxzeOqWpIIhVlG5G0u52rQE4=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=DTElpTF2Qn/IaBTa9jxhtkZ5uzOwfG9EJYNuwd/znTA=; b=ISCCUF6uY7s6xYngOdZXBKt4lg VHVFbYVcbv9g+zPk05rIEFUJEbkGQUS0F5oTvGoKn32Jw8JGQsL9LLdQRx/Qqh1Rb+BAOplcBQg6D w8sIjx+g8Lkc/Zd4CZsV42nds1OJqYkK/Kv4hjhuYMK78JXYNeADJtwm6UlW/QE+6m8E=; Received: from tor.source.kernel.org ([172.105.4.254]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1x1TaS-000316-DO for linux-f2fs-devel@lists.sourceforge.net; Tue, 01 Sep 2026 18:52:03 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id B582C60A81 for ; Tue, 1 Sep 2026 18:51:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3005B1F00A3E; Tue, 1 Sep 2026 18:51:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788288714; bh=DTElpTF2Qn/IaBTa9jxhtkZ5uzOwfG9EJYNuwd/znTA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=gvy3hK2+4VwA8xWxUJnLCFolVKknSpywUJuPwq3DwufQTyePpWEUz+NacHISS8R3H Cn3QVcVjDk0alKhMtuJwPAVTziMaX3gWBIjwheccHCkhUTvc5Y1hebQEtHvJUR3rOh 2/aTJPMOw3t6YKKJI+OyfDxnBkiQX/nPOrMztiXWWdaThjB+n0i0xo6ctaCTZ4v1yD wdDG6Z7cZQ7qnKFvHR1Vn39OxXNl9faMkk5Od+iUGo47kRd8cki7vctKGKjVoiugF4 egymNTSWd4H49ToeYHqnlw1P9LJO9i80+9IKl5atvXvrmzA0fHSCPPJNdz5a/R7hnb +/hk+fV9+/fMQ== Date: Wed, 2 Sep 2026 02:51:48 +0800 To: Anand Jain Message-ID: Mail-Followup-To: Anand Jain , fstests@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, djwong@kernel.org References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Headers-End: 1x1TaS-000316-DO Subject: Re: [f2fs-dev] [PATCH v8 08/13] fstests: verify f_fsid for cloned filesystems X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Zorro Lang via Linux-f2fs-devel Reply-To: Zorro Lang Cc: djwong@kernel.org, fstests@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Sat, Jul 25, 2026 at 03:39:05PM +0800, Anand Jain wrote: > Verify that the cloned filesystem provides an f_fsid that is persistent > across mount cycles, yet unique from the original filesystem's f_fsid. > > Signed-off-by: Anand Jain > --- > tests/generic/802 | 64 +++++++++++++++++++++++++++++++++++++++++++ > tests/generic/802.out | 4 +++ > 2 files changed, 68 insertions(+) > create mode 100644 tests/generic/802 > create mode 100644 tests/generic/802.out > > diff --git a/tests/generic/802 b/tests/generic/802 > new file mode 100644 > index 000000000000..910807c11584 > --- /dev/null > +++ b/tests/generic/802 > @@ -0,0 +1,64 @@ > +#! /bin/bash > +# SPDX-License-Identifier: GPL-2.0 > +# Copyright (c) 2026 Anand Jain . All Rights Reserved. > +# > +# FS QA Test 802 > +# Check that the cloned filesystem provides an f_fsid that is persistent > +# across mount cycles if the block device maj:min remains unchanged. > + > +. ./common/preamble > + > +_begin_fstest auto quick mount clone > + > +_require_test > +_require_block_device $TEST_DEV > +_require_loop > + > +_fixed_by_fs_commit btrfs xxxxxxxxxxxx \ > + "btrfs: use on-disk uuid for s_uuid in temp_fsid mounts" > +_fixed_by_fs_commit btrfs xxxxxxxxxxxx \ > + "btrfs: derive f_fsid from on-disk fsuuid and dev_t" > + > +_cleanup() > +{ > + cd / > + rm -r -f $tmp.* > + umount $mnt1 $mnt2 2>/dev/null > + _loop_image_destroy "${devs[@]}" 2> /dev/null > +} > + > +# Setup base loop device and its clone > +devs=() > +_loop_image_create_clone devs > +mkdir -p $TEST_DIR/$seq Better to `rm -rf $TEST_DIR/$seq` before creating a new one. > +mnt1=$TEST_DIR/$seq/mnt1 > +mnt2=$TEST_DIR/$seq/mnt2 > +mkdir -p $mnt1 > +mkdir -p $mnt2 > + > +# Mount both filesystems simultaneously using mandatory clone mount options > +_mount $(_common_dev_mount_options) $(_clone_mount_option) ${devs[0]} $mnt1 || \ > + _fail "Failed to mount dev1" > +_mount $(_common_dev_mount_options) $(_clone_mount_option) ${devs[1]} $mnt2 || \ > + _fail "Failed to mount dev2" > + > +# Capture baseline filesystem IDs for comparison > +fsid_scratch=$(stat -f -c "%i" $mnt1) > +fsid_clone=$(stat -f -c "%i" $mnt2) > + > +# Verify that the fsids remain stable after a mount cycle, even when the > +# mount order is reversed. > +echo "**** fsid after mount cycle ****" > +_unmount $mnt1 > +_unmount $mnt2 > +_mount $(_common_dev_mount_options) $(_clone_mount_option) ${devs[1]} $mnt2 || \ > + _fail "Failed to mount dev2" > +_mount $(_common_dev_mount_options) $(_clone_mount_option) ${devs[0]} $mnt1 || \ > + _fail "Failed to mount dev1" > + > +# Compare post mount-cycle values against the baseline > +stat -f -c "%i" $mnt1 | sed -e "s/$fsid_scratch/FSID_SCRATCH/g" > +stat -f -c "%i" $mnt2 | sed -e "s/$fsid_clone/FSID_CLONE/g" Hmm... what if "$fsid_scratch" is same with "$fsid_clone"? > + > +status=0 > +exit _exit 0 > diff --git a/tests/generic/802.out b/tests/generic/802.out > new file mode 100644 > index 000000000000..0202a9a2c108 > --- /dev/null > +++ b/tests/generic/802.out > @@ -0,0 +1,4 @@ > +QA output created by 802 > +**** fsid after mount cycle **** > +FSID_SCRATCH > +FSID_CLONE > -- > 2.43.0 > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel