All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Sasha Levin <sashal@kernel.org>
Cc: stable@vger.kernel.org, Tom Lendacky <thomas.lendacky@amd.com>,
	 Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 6.12.y 2/3] KVM: SEV: Add an anonymous "psc" struct to track current PSC metadata
Date: Tue, 1 Sep 2026 12:01:32 -0700	[thread overview]
Message-ID: <apchDJDrXemR0paW@google.com> (raw)
In-Reply-To: <20260831211010.1798943-2-sashal@kernel.org>

On Mon, Aug 31, 2026, Sasha Levin wrote:
> From: Sean Christopherson <seanjc@google.com>
> 
> [ Upstream commit 00b9744a3688758c5c492756d08a1cd599a76965 ]
> 
> Add a "psc" struct to vcpu_sev_es_state to avoid having to prefix all of
> the fields with "psc_".
> 
> Take advantage of the code churn to opportunistically rename local
> variables to "guest_psc" to make it more obvious that the buffer is guest
> data, and more importantly, guest accessible!
> 
> Opportunistically rename inflight => batch_size as well, because there can
> really only be one operation in-flight (per-vCPU), i.e. "inflight" _looks_
> like a boolean, but in actuality is an integer tracking how many pages are
> being handled by the current operation.
> 
> No functional change intended.
> 
> Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com>
> Signed-off-by: Sean Christopherson <seanjc@google.com>
> Message-ID: <20260501202250.2115252-13-seanjc@google.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> Message-ID: <20260529183549.1104619-13-pbonzini@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> 
> For the 6.12 backport, retain the existing GHCB response write because the
> newer VMGEXIT response helper is not available.  Also fold in the VMSA GPA
> tracking and helper refactoring needed by the dependent AP_CREATE fix,
> adapting them to the 6.12 gmem and MP-state APIs and existing reset hook
> without adding a new function.

NAK.

As the first sentence says, grabbing 00b9744a3688 ("KVM: SEV: Add an anonymous
"psc" struct to track current PSC metadata") only requires handling a superficial
syntactic conflict.  This mixes in pieces of d1a3c2162334 ("KVM: SEV: Forcefully
invalidate SNP VMSA if its backing gmem page is zapped"), and *that* is the
commit that's by far the most interesting.  I.e. pretty much all of this is
leading up to that commit, not these intermediate commits.

  reply	other threads:[~2026-09-01 19:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-31 12:25 FAILED: patch "[PATCH] KVM: SEV: Mark vCPU RUNNABLE after AP_CREATE, even if VMSA is" failed to apply to 6.12-stable tree gregkh
2026-08-31 21:10 ` [PATCH 6.12.y 1/3] KVM: SEV: Make it more obvious when KVM is writing back the current PSC index Sasha Levin
2026-08-31 21:10   ` [PATCH 6.12.y 2/3] KVM: SEV: Add an anonymous "psc" struct to track current PSC metadata Sasha Levin
2026-09-01 19:01     ` Sean Christopherson [this message]
2026-09-02 22:14       ` Sasha Levin
2026-09-04  0:23         ` Sean Christopherson
2026-09-06 13:32           ` Sasha Levin
2026-08-31 21:10   ` [PATCH 6.12.y 3/3] KVM: SEV: Mark vCPU RUNNABLE after AP_CREATE, even if VMSA is unusable Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=apchDJDrXemR0paW@google.com \
    --to=seanjc@google.com \
    --cc=pbonzini@redhat.com \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=thomas.lendacky@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.