From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: <jerinj@marvell.com>, Rajesh Kumar <rajesh3.kumar@intel.com>,
<dev@dpdk.org>, <thomas@monjalon.net>, <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v1] examples/ptp_tap_relay_sw: fix build inclusion
Date: Wed, 2 Sep 2026 10:41:10 +0100 [thread overview]
Message-ID: <apfvNj3ye24sbGbb@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <CAJFAV8zRf5YuW3O2c7kZRmCTQ_b85DWEMqAE6UjH7ynHO6JCrw@mail.gmail.com>
On Wed, Sep 02, 2026 at 11:09:02AM +0200, David Marchand wrote:
> On Wed, 2 Sept 2026 at 10:25, <jerinj@marvell.com> wrote:
> >
> > From: Jerin Jacob <jerinj@marvell.com>
> >
> > The ptp_tap_relay_sw example was not building because
> > examples/meson.build was not updated to wire up this directory.
>
> Ouch, the whole example looks like dead code.
> I wonder how it was tested by the author...
> The series that introduced it has no trace of touching
> examples/meson.build in the v6, v7 and v8 iterations :-(.
>
>
> >
> > Fixes: bec00deaa8fb ("examples/ptp_tap_relay_sw: add PTP transparent clock relay")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Jerin Jacob <jerinj@marvell.com>
>
> The fix lgtm.
> For the record, it is the only dead example at this point in time in DPDK.
>
It's not dead code, since it was buildable before when it was named using
"examples=" parameter. The list of all examples is only used when
"-Dexamples=all" is passed, so we are just missing this examples from
automated build testing using the "all" param.
next prev parent reply other threads:[~2026-09-02 9:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 8:25 [dpdk-dev] [PATCH v1] examples/ptp_tap_relay_sw: fix build inclusion jerinj
2026-09-02 9:09 ` David Marchand
2026-09-02 9:41 ` Bruce Richardson [this message]
2026-09-02 9:42 ` Bruce Richardson
2026-09-02 15:33 ` [dpdk-dev] [PATCH v2] " jerinj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apfvNj3ye24sbGbb@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=rajesh3.kumar@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.