All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Nirmoy Das <nirmoyd@nvidia.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [RFC PATCH] getrusage03: account for percpu RSS counter batching
Date: Wed, 2 Sep 2026 14:25:30 +0200	[thread overview]
Message-ID: <apgVur5s_potD6ND@yuki.lan> (raw)
In-Reply-To: <20260825152544.1675541-1-nirmoyd@nvidia.com>

Hi!
> getrusage03 allows ru_maxrss to differ from the expected value by a
> fixed 20 MiB. That can be too small on large systems after Linux commit
> f1a7941243c1 ("mm: convert mm's rss stats into percpu_counter").
> 
> The fast RSS read may miss percpu counter batches, and the batch size
> scales with the number of online CPUs. The test child is single threaded,
> but it can migrate while faulting memory, so allow two batches worth of
> slack based on the online CPU count and page size. Keep the existing
> 20 MiB floor for smaller systems.
> 
> This is sent as RFC because it makes the test tolerate Linux's current
> percpu counter batching behavior instead of treating the smaller
> ru_maxrss value as a kernel failure.

Maybe we can pin the whole test to a single CPU instead. Otherwise the
max rss delta can easily get into hundreds of megabytes, which is more
than the test consumes.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2026-09-02 12:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-25 15:25 [LTP] [RFC PATCH] getrusage03: account for percpu RSS counter batching Nirmoy Das via ltp
2026-08-25 17:34 ` [LTP] " linuxtestproject.agent
2026-09-02 12:25 ` Cyril Hrubis [this message]
2026-09-02 16:01   ` [LTP] [PATCH v2] " Nirmoy Das via ltp
2026-09-02 17:42     ` [LTP] " linuxtestproject.agent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=apgVur5s_potD6ND@yuki.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=nirmoyd@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.