All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vincent Jardin <vjardin@free.fr>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: hwmon: ti,tmp401: add #thermal-sensor-cells
Date: Wed, 2 Sep 2026 16:26:27 +0200	[thread overview]
Message-ID: <apgyEzLFXnyXEkPF@L30177.local> (raw)
In-Reply-To: <bc51c907-a523-4b99-bf3a-b23c5823fd56@roeck-us.net>

Hi Guenter,

> The driver does register thermal zones. Since #thermal-sensor-cells is
> mandatory for using it, I would think that the property is needed.

agree. thanks.

> However, not all chips supported by the driver (and this bindings file)
> have more than one channel, so I suspect that the value range might
> need to be "enum: [0, 1]".

I could switch to "enum: [0, 1]" if you would still prefer it, but
tmp401_probe() sets temp_channel_config[0] and [1] unconditionally (local plus
one remote diode) and tmp432 adds [2] for its second remote.
So each case in this binding has at least two channels and the channel index is always
meaningful. That is why "const: 1" is used, matching national,lm90.yaml,
which covers a mix of 2 and 3 channel chips.

I'll send a v3, that does not change the yaml by that applies the proper comments
per Krzysztof's feedbacks.

best regards,
  Vincent

  reply	other threads:[~2026-09-02 14:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-24 22:13 [PATCH v2] dt-bindings: hwmon: ti,tmp401: add #thermal-sensor-cells Vincent Jardin via B4 Relay
2026-08-24 22:13 ` Vincent Jardin
2026-08-24 22:17 ` sashiko-bot
2026-08-28 10:02 ` Krzysztof Kozlowski
2026-09-02 13:28   ` Guenter Roeck
2026-09-02 14:26     ` Vincent Jardin [this message]
2026-09-02 18:04       ` Guenter Roeck
2026-09-02 14:11   ` Vincent Jardin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=apgyEzLFXnyXEkPF@L30177.local \
    --to=vjardin@free.fr \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.