From: Pavel Machek <pavel@nabladev.com>
To: Ovidiu Panait <ovidiu.panait.rb@renesas.com>
Cc: cip-dev@lists.cip-project.org, pavel@nabladev.com,
nobuhiro.iwamatsu.x90@mail.toshiba
Subject: Re: [PATCH 6.1.y-cip 03/11] irqchip/renesas-rzv2h: Use local device pointer in ICU probe
Date: Wed, 2 Sep 2026 18:57:30 +0200 [thread overview]
Message-ID: <aphVet4W9UIunoEv@duo.ucw.cz> (raw)
In-Reply-To: <20260902092353.24648-4-ovidiu.panait.rb@renesas.com>
[-- Attachment #1: Type: text/plain, Size: 964 bytes --]
Hi!
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> commit bbe78cb1399b4ba6b6d14943fb9dadefe9c17b5b upstream.
>
> Use a local struct device pointer in rzv2h_icu_probe_common() to avoid
> repeated dereferencing of pdev->dev.
>
> --- a/drivers/irqchip/irq-renesas-rzv2h.c
> +++ b/drivers/irqchip/irq-renesas-rzv2h.c
> @@ -625,14 +627,14 @@ static int rzv2h_icu_init_common(struct device_node *node, struct device_node *p
>
> /*
> * coccicheck complains about a missing put_device call before returning, but it's a false
> - * positive. We still need &pdev->dev after successfully returning from this function.
> + * positive. We still need dev after successfully returning from this function.
> */
> return 0;
I believe the search and replace went too far here. For reader,
original comment was more useful. But maybe it should say in english
what device we actually need.
Best regards,
Pavel
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2026-09-02 16:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 9:23 [PATCH 6.1.y-cip 00/11] Add ICU error and software interrupt support for RZ/V2H and RZ/V2N Ovidiu Panait
2026-09-02 9:23 ` [PATCH 6.1.y-cip 01/11] irqchip/renesas-rzv2h: Fix error path in rzv2h_icu_probe_common() Ovidiu Panait
2026-09-02 9:23 ` [PATCH 6.1.y-cip 02/11] irqchip/renesas-rzv2h: Use local node pointer Ovidiu Panait
2026-09-02 9:23 ` [PATCH 6.1.y-cip 03/11] irqchip/renesas-rzv2h: Use local device pointer in ICU probe Ovidiu Panait
2026-09-02 16:57 ` Pavel Machek [this message]
2026-09-02 9:23 ` [PATCH 6.1.y-cip 04/11] irqchip/renesas-rzv2h: Switch to using dev_err_probe() Ovidiu Panait
2026-09-02 9:23 ` [PATCH 6.1.y-cip 05/11] irqchip/renesas-rzv2h: Clarify IRQ range definitions and tighten TINT validation Ovidiu Panait
2026-09-02 9:23 ` [PATCH 6.1.y-cip 06/11] irqchip/renesas-rzv2h: Replace single irq_chip with per-region irq_chip instances Ovidiu Panait
2026-09-02 9:23 ` [PATCH 6.1.y-cip 07/11] irqchip/renesas-rzv2h: Add CA55 software interrupt support Ovidiu Panait
2026-09-02 9:23 ` [PATCH 6.1.y-cip 08/11] irqchip/renesas-rzv2h: Handle ICU error IRQ and add SWPE trigger Ovidiu Panait
2026-09-02 17:00 ` Pavel Machek
2026-09-02 9:23 ` [PATCH 6.1.y-cip 09/11] irqchip/renesas-rzv2h: Kill swint_idx[] Ovidiu Panait
2026-09-02 9:23 ` [PATCH 6.1.y-cip 10/11] irqchip/renesas-rzv2h: Kill swint_names[] Ovidiu Panait
2026-09-02 9:23 ` [PATCH 6.1.y-cip 11/11] irqchip/renesas-rzv2h: Kill icu_err string Ovidiu Panait
2026-09-02 17:00 ` [PATCH 6.1.y-cip 00/11] Add ICU error and software interrupt support for RZ/V2H and RZ/V2N Pavel Machek
2026-09-03 19:33 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aphVet4W9UIunoEv@duo.ucw.cz \
--to=pavel@nabladev.com \
--cc=cip-dev@lists.cip-project.org \
--cc=nobuhiro.iwamatsu.x90@mail.toshiba \
--cc=ovidiu.panait.rb@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.