All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ratheesh Kannoth <rkannoth@marvell.com>
To: <bpf@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<netdev@vger.kernel.org>
Cc: <andrew+netdev@lunn.ch>, <ast@kernel.org>, <daniel@iogearbox.net>,
	<davem@davemloft.net>, <edumazet@google.com>, <hawk@kernel.org>,
	<john.fastabend@gmail.com>, <kuba@kernel.org>,
	<pabeni@redhat.com>, <sdf@fomichev.me>, <sgoutham@marvell.com>
Subject: Re: [PATCH v11 net-next] octeontx2-pf: add mqprio bandwidth offload for NIX TX schedulers
Date: Thu, 3 Sep 2026 07:59:52 +0530	[thread overview]
Message-ID: <apjboPTH53wIfke0@rkannoth-OptiPlex-7090> (raw)
In-Reply-To: <20260902015500.2985371-1-rkannoth@marvell.com>

On 2026-09-02 at 07:25:00, Ratheesh Kannoth (rkannoth@marvell.com) wrote:
> Add TC_SETUP_QDISC_MQPRIO offload for channel-mode mqprio with
> TC_MQPRIO_SHAPER_BW_RATE. Program per-queue MDQ CIR/PIR through the
> NIX TX scheduler mailbox for each non-QoS transmit queue. When offload
> is active, allocate one SMQ per such queue, parent every MDQ under
> TL4[0], and map each traffic class min/max rate to the queue(s) in that
> class.
>
> Rebuild the TX scheduler hierarchy by bouncing the netdev through
> ndo_stop() and ndo_open() on mqprio add, replace, and delete. Cache
> the active rates and restore MDQ shapers from otx2_mqprio_up() during
> ndo_open(); log and continue if restoration fails so a normal open is
> not blocked.
>
> Track mqprio configuration in mq_offload_snap snapshots (TC layout and
> rates). On tc qdisc replace, stage the new configuration while keeping
> the previous snapshot for rollback: failed setup restores the old
> snapshot, successful graft is recorded through TC_ROOT_GRAFT, and
> teardown of the replaced qdisc instance commits the staged snapshot
> without tearing down the live offload.
>
> Reject offload unless the interface is running and the device advertises
> CIR+PIR support. Reject per-TC rates for traffic classes mapped to more
> than one queue, SDP rep ports, and concurrent PFC or XDP use. Block
> ethtool channel count changes while mqprio bandwidth offload is active.
>
> Add a ratelimited AF debug message when validating TX scheduler queue
> ownership to aid mqprio hierarchy setup failures.
>
> Signed-off-by: Ratheesh Kannoth <rkannoth@marvell.com>

Will address sashiko reviews in v12.

pw-bot: changes-requested

  parent reply	other threads:[~2026-09-03  2:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-02  1:55 [PATCH v11 net-next] octeontx2-pf: add mqprio bandwidth offload for NIX TX schedulers Ratheesh Kannoth
2026-09-03  1:55 ` sashiko-bot
2026-09-03  2:29 ` Ratheesh Kannoth [this message]
2026-09-07  7:58 ` netdev-bot+sashiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=apjboPTH53wIfke0@rkannoth-OptiPlex-7090 \
    --to=rkannoth@marvell.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hawk@kernel.org \
    --cc=john.fastabend@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sdf@fomichev.me \
    --cc=sgoutham@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.