From: Guillaume Nault <gnault@redhat.com>
To: Ido Schimmel <idosch@nvidia.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
pabeni@redhat.com, edumazet@google.com, dsahern@kernel.org,
horms@kernel.org, aconole@redhat.com, sbrivio@redhat.com,
laikabcprice@gmail.com, aroslavdudkov622@gmail.com,
rough.rock3059@datachamp.fr, stable@vger.kernel.org
Subject: Re: [PATCH net] tunnels: Drop stale dst when building an ICMP error for PMTUD
Date: Thu, 3 Sep 2026 11:28:05 +0200 [thread overview]
Message-ID: <apk9pZv3wu5WtEMU@debian> (raw)
In-Reply-To: <20260902190112.4126199-1-idosch@nvidia.com>
On Wed, Sep 02, 2026 at 10:01:12PM +0300, Ido Schimmel wrote:
> Bridged UDP tunnels such as VXLAN and GENEVE build an ICMP error packet
> around an overlay packet if the packet is going to exceed the underlay
> path MTU. The ICMP error packet is then injected back into the Rx path
> with the source and destination addresses swapped, so that it will be
> delivered to the overlay source.
>
> If the overlay packet was routed to the UDP tunnel or locally generated,
> then it is already carrying a valid dst entry and this entry is not
> dropped when transforming the packet to an ICMP error packet. This
> causes the IP layer to reuse the dst entry, leading to the ICMP error
> packet being dropped or routed out of the UDP tunnel interface in case
> of forwarding.
Good catch, thanks!
Reviewed-by: Guillaume Nault <gnault@redhat.com>
next prev parent reply other threads:[~2026-09-03 9:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 19:01 [PATCH net] tunnels: Drop stale dst when building an ICMP error for PMTUD Ido Schimmel
2026-09-02 19:50 ` Yaroslav Dudkov
2026-09-02 20:23 ` David Ahern
2026-09-03 7:55 ` Stefano Brivio
2026-09-03 9:28 ` Guillaume Nault [this message]
2026-09-04 0:50 ` patchwork-bot+netdevbpf
2026-09-04 17:09 ` Aaron Conole
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apk9pZv3wu5WtEMU@debian \
--to=gnault@redhat.com \
--cc=aconole@redhat.com \
--cc=aroslavdudkov622@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=laikabcprice@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rough.rock3059@datachamp.fr \
--cc=sbrivio@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.