From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Tsz Shan Chan <tsz.chan.dev@gmail.com>
Cc: "Subhajit Ghosh" <subhajit.ghosh@tweaklogic.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
"Tsz Shan Chan" <tchan@jacques.com.au>
Subject: Re: [PATCH v2] iio: light: apds9306: fix default sampling frequency definition
Date: Thu, 3 Sep 2026 10:48:27 +0300 [thread overview]
Message-ID: <apkmS32q9UI-qQw1@ashevche-desk.local> (raw)
In-Reply-To: <20260903-apds9306-v2-1-e8673986ae56@jacques.com.au>
On Thu, Sep 03, 2026 at 05:05:35PM +1000, Tsz Shan Chan wrote:
> APDS9306_SAMP_FREQ_10HZ is defined as 0.
>
> According to the datasheet (Broadcom AV02-4755EN,
> https://docs.broadcom.com/doc/AV02-4755EN, page 11, ALS_MEAS_RATE),
Make it a tag
> bits[2:0] set the measurement rate:
> - 000: 25ms (40Hz)
> - 001: 20ms (20Hz)
> - 010: 100ms (10Hz)
>
> Change APDS9306_SAMP_FREQ_10HZ from 0 to 2 to write the correct value
> for 10Hz.
Datasheet: $URL
> Fixes: 620d1e6c7a3f ("iio: light: Add support for APDS9306 Light Sensor")
> Signed-off-by: Tsz Shan Chan <tchan@jacques.com.au>
With that being addressed,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-09-03 7:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 7:05 [PATCH v2] iio: light: apds9306: fix default sampling frequency definition Tsz Shan Chan
2026-09-03 7:48 ` Andy Shevchenko [this message]
2026-09-04 1:18 ` Tsz Shan Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apkmS32q9UI-qQw1@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=subhajit.ghosh@tweaklogic.com \
--cc=tchan@jacques.com.au \
--cc=tsz.chan.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.