Re: [PATCH 1/4] meson: simplify clang version checks

["Daniel P. Berrangé" <berrange@redhat.com>]

On Thu, Sep 03, 2026 at 03:35:48PM +0400, Marc-André Lureau wrote:
> Hi
> 
> On Thu, Sep 3, 2026 at 2:35 PM Daniel P. Berrangé <berrange@redhat.com> wrote:
> >
> > The checks for the clang minor versions are currently redundant since
> > there can never be a minor version less than zero. Going forward it
> > is likely sufficient to always pick a NN.0.0 release as the min CLang
> > version, so drop the minor version checks.
> >
> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> 
> This is basically since your commit 2a85a08c998. I'm happy if that is
> enough on macos:
> Acked-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Yes, we should arguably add a "Fixes: 2a85a08c998", since that
introduced the bogus  < 0 comparison.

> 
> 
> > ---
> >  meson.build | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/meson.build b/meson.build
> > index 5c9de307b0..70e2755149 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -330,11 +330,11 @@ foreach lang : all_languages
> >      # ok
> >    elif compiler.get_id() == 'clang' and compiler.compiles('''
> >        #ifdef __apple_build_version__
> > -      # if __clang_major__ < 15 || (__clang_major__ == 15 && __clang_minor__ < 0)
> > +      # if __clang_major__ < 15
> >        #  error You need at least XCode Clang v15.0 to compile QEMU
> >        # endif
> >        #else
> > -      # if __clang_major__ < 10 || (__clang_major__ == 10 && __clang_minor__ < 0)
> > +      # if __clang_major__ < 10
> >        #  error You need at least Clang v10.0 to compile QEMU
> >        # endif
> >        #endif''')
> > --
> > 2.55.0
> >
> 

With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|