Re: [PATCH] scripts/checkpatch: warn on duplicate trailers and self-review

["Daniel P. Berrangé" <berrange@redhat.com>]

On Mon, Jul 27, 2026 at 08:11:56PM +0400, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> Detect two common trailer mistakes:
> 
> - Duplicate trailers: any trailer (Signed-off-by, Fixes, Resolves,
>   Cc, etc.) appearing more than once with the same value in a commit
>   message.
> 
> - Self-review: a Reviewed-by, Tested-by, or Acked-by tag from the
>   same person as the patch author, which provides no independent
>   review value.

That could happen if someone starts a patch, then someone else
takes over and does more, then the original author tests/reviews
the result. Since this is merely a warning though, I think that
its fine to ignore.

> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  scripts/checkpatch.pl | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|