From: Oleg Nesterov <oleg@redhat.com>
To: Karl Mehltretter <kmehltretter@gmail.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] super: remember whether freeze holds writer rwsems
Date: Thu, 3 Sep 2026 14:44:19 +0200 [thread overview]
Message-ID: <aplro1ObQ5YNZT6R@redhat.com> (raw)
In-Reply-To: <20260903060855.4610-1-kmehltretter@gmail.com>
On 09/03, Karl Mehltretter wrote:
>
> Record whether a successful freeze acquired the writer rwsems and use that
> state during thaw instead of re-sampling SB_RDONLY.
Looks correct at first glance, but I leave this to other reviewers,
I don't understand fs/ enough.
> Tested with a test-only KUnit case in x86_64 QEMU on linux-next
> 32b6ef9a5d0e (next-20260902). It freezes a writable ramfs, sets SB_RDONLY,
> thaws it, and calls sb_start_write_trylock(). The call fails without this
> patch and succeeds with it.
But I am curious, how exactly did you test this?
ramfs_ops doesn't have ->freeze_fs or ->freeze_super, so
ioctl_fsfreeze() should fail?
And how it is possible to remount with -ro, reconfigure_super() should
see sb->s_writers.frozen != SB_UNFROZEN ?
Oleg.
next prev parent reply other threads:[~2026-09-03 12:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 6:08 [PATCH] super: remember whether freeze holds writer rwsems Karl Mehltretter
2026-09-03 10:40 ` Jan Kara
2026-09-03 19:50 ` Karl Mehltretter
2026-09-04 9:31 ` Jan Kara
2026-09-03 12:44 ` Oleg Nesterov [this message]
2026-09-03 19:36 ` Karl Mehltretter
2026-09-03 21:43 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aplro1ObQ5YNZT6R@redhat.com \
--to=oleg@redhat.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=kmehltretter@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.