From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5BA1FC624A4 for ; Thu, 3 Sep 2026 15:37:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6DCFB6B008A; Thu, 3 Sep 2026 11:37:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 68D626B008C; Thu, 3 Sep 2026 11:37:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A4576B0092; Thu, 3 Sep 2026 11:37:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 34E4C6B008A for ; Thu, 3 Sep 2026 11:37:42 -0400 (EDT) Received: from smtpin13.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 929E41205A2 for ; Thu, 3 Sep 2026 15:37:41 +0000 (UTC) X-FDA: 85172855922.13.A45FC82 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf09.hostedemail.com (Postfix) with ESMTP id D2806140011 for ; Thu, 3 Sep 2026 15:37:39 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b=XwbiNMYl; spf=pass (imf09.hostedemail.com: domain of jaegeuk@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=jaegeuk@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; d=hostedemail.com; s=arc-20220608; cv=none; t=1788449860; b=rDafAbvct3RXZThsYaPzyKRFCVlCgloHIyFjZA4IRtVyx6WOunl6E6NgKMSh4yVbVVLc9z dubdO5cm6LKQ6pxX2dyMfPPTF+wHK1KWwuIXUye44jivxwzfgX7Edv3+N/rbSCQpz8PS/7 W4dhDo90vDuyUfDrukFNsneFDjwAxh4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1788449860; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SAaGuiuwmKSEyoiV8Zah8K/3km4skoA5hchj++a6j6E=; b=a1gj7Q2QQWLgVSZDu4m720fGljsTYxj+389aktj0IyGxlHexmuB0G85iqCwK0kNZXd7Rl3 ZXRzZfPI/evK0Qjy+WrbcSY2DEHiQa9jBHa0cmLTKJj3rGZtUWf491WNfggnOYhm8wpC8Y ApWlGxsNnxBVyPgtnLamk+2G5YNRCLA= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b=XwbiNMYl; spf=pass (imf09.hostedemail.com: domain of jaegeuk@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=jaegeuk@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 5001441193; Thu, 3 Sep 2026 15:37:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1A1A21F00A3A; Thu, 3 Sep 2026 15:37:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788449858; bh=SAaGuiuwmKSEyoiV8Zah8K/3km4skoA5hchj++a6j6E=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=XwbiNMYlFIe5noAKSrlUGhYbLna2L+uP8lSXziXkAW62TAf8hQPWn9u+lWp6iYyo4 2406vNU8X6hwJGPli4Z0q2ege3NMjGMxsocs4c0PQ+1U/F7zAodiC1YypWAr0O5cy4 JvFisieON+V/L86uWXU8vC5wKcx8Q6Qq/rjmneZl4FpCLZj/CgxrhuDEI0TmUN61y9 jlbnpKu3/KYACkoWnURxOuutOBHRIFQ+cB9Qf1djpVCrt86thiQG0Qgm/le+dZBfqH JTXDJXvobCVYMvtofNtJ6HRcgwWaVWeQ/J7GSBdP4bQ81ERzGbrHQfpvFQcV0FeHCi uM0wXamhjq7Sw== Date: Thu, 3 Sep 2026 15:37:35 +0000 From: Jaegeuk Kim To: Zi Yan Cc: David Hildenbrand , "Matthew Wilcox (Oracle)" , Andrew Morton , Muchun Song , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Usama Arif , Gregory Price , Ying Huang , Alistair Popple , Johannes Weiner , Qi Zheng , Shakeel Butt , Kairui Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Chao Yu , linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCH v2 06/14] f2fs: stop using PG_private Message-ID: References: <20260831-remove-pg_private-v2-0-3668159cd9e8@nvidia.com> <20260831-remove-pg_private-v2-6-3668159cd9e8@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260831-remove-pg_private-v2-6-3668159cd9e8@nvidia.com> X-Rspam-User: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: D2806140011 X-Stat-Signature: 6ry17ddw5o3nbxh1fsqdzwec44kwjfic X-HE-Tag: 1788449859-472150 X-HE-Meta: U2FsdGVkX1/952p0m4/lcblrQZB47tAuDRzkP5hU8Q427KRo/E30TaUqotlmrZveumo5xq7vGfA25F08G1FeuMGwZ2EPA794/3m1TdJ/K3HlRYV38RPkUUD8prKRm466H42LwMkgdg7oZ5gACQXNmANQyHlmQm9eP4+AIjc48SSvj1Z8GCpoZ3hsjuBPftuNWiS8y2PPRbFq+Vg8xhmXZVoKG9G8a50K0WJ50WkSI8tjDlBASy1f2VvbQnyv/3aBwC7LhFZOsXIUPVe/EADC/soqfBC00wgE8itXL6UxkazazJzchb2Zy6QYQLDEhc7Cbfj82RsfPb4Wc1KiBHeV7+tQH0YbcrQmlpeul8zBf3gdHSddoD9eWYtHJp0NUWgpNVMvqEMtPjyPNanqXmxFRtpHOdV7GUhcOPlXbrlqlgbrxJ53O/4fX7G6GjvtuWYj4r8PywDDDtDsG8uVPuw1yfU2JtNbHk7JBDEjW5O+B6p3XmdN4lNIqrcHwkDKLOvLKRy00Rx7oN3ye6C38Y4ksJ3oK1O9JaFTkvqCgxDlqq48s1/Ei+kVHpKZ6zEVoRDBp2+4uQRCicPJzN5hAVXcBxMLl9V9+fFh+zr3CSKHZR6OcZK0ZfxDkzkaQTD0GbSfTBvsFo8i0SWLLtjZWuKV7KQQ8bhScylzE/EQftvkzKdtPSYVFKQzka1Uf6xTAgl3TfnyFxHRtQPT/qJtY30vtYH6e2VERFfTr4YAQwLeddhr6iFG2z8E4pySCVSKEX1NkAlWn4wIrELBvdZW+iK36/FJ2lXj0j0so/rRsX8qjNmIyIolwgPmHD4o4aXB3CJa+5KTB/3NdoZJW58jkDaHHrb1IDFR0Om4Km0xXu3nhz/e428jwg05XsdBhzbtJFnNK1I9Nm7BYaRbVrbaA50TwEeHmNhOMGp9BIdtXdhiPr3cjqhlXS92l5FP7jNFN4gUlEeIDWMP64yCCRIgiwa qQ1mxg03 qksnGOl8KAauTMG5lkO9cMEh7bl1rjWVAI1Rhbat4egVxF+t8kfK2dQ2HcdkuSFluEO7B18z+zYlJ7eWIu/Hml0RJv7Q+Od2u51W0XynI8f8ih5/UVu+VFOB11BPPE4SMCVBt5CFfnyQA+Iez3cDDT11jIrrY6aKQOGn7haxpv8QxngvXEuxbeTPJC6EsBdEoFuilYtGdJX2W7ZZvGT1BIlGV2s2fvpgCScDoq/ZtCzUtLhOUOwjIdnEYdI8Z0A3tu8VTW9Ur8/z+phN9r3uKJLXCq//LTqMg4wE8pac45HSbyzTYJsA5hzac9jOlOuF2u2D/qQJPwskcz1j8JB3YAzUgV+5D6hOU0VZ4dST8RC38R4K1FsqpXmh1Ow== Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Let me take this patch in f2fs tree, which looks like a clean up. On 08/31, Zi Yan wrote: > f2fs sets its PAGE_PRIVATE_* flags in page->private and checking > page->private != NULL is equivalent to checking PG_private. Change > PagePrivate() to page_private(). Meanwhile, in set_page_private_##name(), > page->private is first set to 0/NULL before an PAGE_PRIVATE_* flag is set, > but it can cause confusion when PG_private is removed and > page->private != NULL is used instead. Change it to initialize > page->private to PAGE_PRIVATE_NOT_POINTER instead and retain the original > semantics. > > It prepares for a future commit that removes PG_private. > > No functional change intended. > > Assisted-by: Claude:claude-opus-4-8 > Assisted-by: Codex:gpt-5 > To: Jaegeuk Kim > To: Chao Yu > Cc: linux-f2fs-devel@lists.sourceforge.net > Cc: linux-kernel@vger.kernel.org > Acked-by: Usama Arif > Acked-by: Chao Yu > Signed-off-by: Zi Yan > --- > fs/f2fs/f2fs.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h > index 9940a6cecf1a2..2f7ab5888b078 100644 > --- a/fs/f2fs/f2fs.h > +++ b/fs/f2fs/f2fs.h > @@ -2691,7 +2691,7 @@ static inline bool folio_test_f2fs_##name(const struct folio *folio) \ > } \ > static inline bool page_private_##name(struct page *page) \ > { \ > - return PagePrivate(page) && \ > + return page_private(page) && \ > test_bit(PAGE_PRIVATE_NOT_POINTER, &page_private(page)) && \ > test_bit(PAGE_PRIVATE_##flagname, &page_private(page)); \ > } > @@ -2710,9 +2710,9 @@ static inline void folio_set_f2fs_##name(struct folio *folio) \ > } \ > static inline void set_page_private_##name(struct page *page) \ > { \ > - if (!PagePrivate(page)) \ > - attach_page_private(page, (void *)0); \ > - set_bit(PAGE_PRIVATE_NOT_POINTER, &page_private(page)); \ > + if (!page_private(page)) \ > + attach_page_private(page, \ > + (void *)BIT(PAGE_PRIVATE_NOT_POINTER)); \ > set_bit(PAGE_PRIVATE_##flagname, &page_private(page)); \ > } > > > -- > 2.53.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A40EBC624A4 for ; Thu, 3 Sep 2026 15:37:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:In-Reply-To:MIME-Version:References: Message-ID:To:Date:Sender:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=l4TwCv01SrLRUXFmaKo6O+TCNT414pO38yPpOBONgFY=; b=FrRqJ2lefZEmss3mZ+em50abH3 VMCxBxDbZsjFjY2s3fvg3EQpNrTlPmUVGQSBHlfJ6dBMXmCj8rfbJ0fXPVNHdueXpI6hl8I8pd+DV gWQhSkS4mHgHuD5qJpjcimZBooe4+Iks5Zx0SBOhBiIMdhi6F/+c8fK/U23EF8vioSSQ=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1x29VZ-0002cF-JK; Thu, 03 Sep 2026 15:37:46 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1x29VY-0002c8-B6 for linux-f2fs-devel@lists.sourceforge.net; Thu, 03 Sep 2026 15:37:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=SAaGuiuwmKSEyoiV8Zah8K/3km4skoA5hchj++a6j6E=; b=YbAK6YqYxYr8ks3FWq0/FVvGk0 oN620Fc++Vr5fqaYbzLwbxDvKg3IqZCxKcPz+u25hDr+Meeugc9TMNrELSkI147OxWhAzWCpiEUNd gzYOUhpU9+2MZ2sdJu0PROdPjYbnuuWhGJrcHk0aLBzuWFthyWZK7Q75KLe/u61MRzxk=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=SAaGuiuwmKSEyoiV8Zah8K/3km4skoA5hchj++a6j6E=; b=TgrGCil8zKp9kQK48x7wNBb+Ij HI8Gq93Gq7n35x9BPnUhtd18fsOlX+dimAU24U2B/Wwb6/xVNNjxWSdvVJe4TOCJVnf2roNE070/T K8g/tTNOdneWbRs/B8YHllxB525TLkUx9XcewawU6/TMgtohF1uP0xpfrmRdMUU7TJ0Q=; Received: from sea.source.kernel.org ([172.234.252.31]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1x29VX-0000Ea-Nd for linux-f2fs-devel@lists.sourceforge.net; Thu, 03 Sep 2026 15:37:45 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 5001441193; Thu, 3 Sep 2026 15:37:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1A1A21F00A3A; Thu, 3 Sep 2026 15:37:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788449858; bh=SAaGuiuwmKSEyoiV8Zah8K/3km4skoA5hchj++a6j6E=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=XwbiNMYlFIe5noAKSrlUGhYbLna2L+uP8lSXziXkAW62TAf8hQPWn9u+lWp6iYyo4 2406vNU8X6hwJGPli4Z0q2ege3NMjGMxsocs4c0PQ+1U/F7zAodiC1YypWAr0O5cy4 JvFisieON+V/L86uWXU8vC5wKcx8Q6Qq/rjmneZl4FpCLZj/CgxrhuDEI0TmUN61y9 jlbnpKu3/KYACkoWnURxOuutOBHRIFQ+cB9Qf1djpVCrt86thiQG0Qgm/le+dZBfqH JTXDJXvobCVYMvtofNtJ6HRcgwWaVWeQ/J7GSBdP4bQ81ERzGbrHQfpvFQcV0FeHCi uM0wXamhjq7Sw== Date: Thu, 3 Sep 2026 15:37:35 +0000 To: Zi Yan Message-ID: References: <20260831-remove-pg_private-v2-0-3668159cd9e8@nvidia.com> <20260831-remove-pg_private-v2-6-3668159cd9e8@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260831-remove-pg_private-v2-6-3668159cd9e8@nvidia.com> X-Headers-End: 1x29VX-0000Ea-Nd Subject: Re: [f2fs-dev] [PATCH v2 06/14] f2fs: stop using PG_private X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Jaegeuk Kim via Linux-f2fs-devel Reply-To: Jaegeuk Kim Cc: Michal Hocko , "Liam R. Howlett" , Shakeel Butt , Ying Huang , Qi Zheng , Vlastimil Babka , Alistair Popple , Dev Jain , "Matthew Wilcox \(Oracle\)" , Gregory Price , Ryan Roberts , Usama Arif , linux-f2fs-devel@lists.sourceforge.net, Baolin Wang , David Hildenbrand , Lorenzo Stoakes , Suren Baghdasaryan , Barry Song , Kairui Song , linux-mm@kvack.org, Muchun Song , linux-kernel@vger.kernel.org, Nico Pache , Lance Yang , Johannes Weiner , Andrew Morton , Mike Rapoport Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net Let me take this patch in f2fs tree, which looks like a clean up. On 08/31, Zi Yan wrote: > f2fs sets its PAGE_PRIVATE_* flags in page->private and checking > page->private != NULL is equivalent to checking PG_private. Change > PagePrivate() to page_private(). Meanwhile, in set_page_private_##name(), > page->private is first set to 0/NULL before an PAGE_PRIVATE_* flag is set, > but it can cause confusion when PG_private is removed and > page->private != NULL is used instead. Change it to initialize > page->private to PAGE_PRIVATE_NOT_POINTER instead and retain the original > semantics. > > It prepares for a future commit that removes PG_private. > > No functional change intended. > > Assisted-by: Claude:claude-opus-4-8 > Assisted-by: Codex:gpt-5 > To: Jaegeuk Kim > To: Chao Yu > Cc: linux-f2fs-devel@lists.sourceforge.net > Cc: linux-kernel@vger.kernel.org > Acked-by: Usama Arif > Acked-by: Chao Yu > Signed-off-by: Zi Yan > --- > fs/f2fs/f2fs.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h > index 9940a6cecf1a2..2f7ab5888b078 100644 > --- a/fs/f2fs/f2fs.h > +++ b/fs/f2fs/f2fs.h > @@ -2691,7 +2691,7 @@ static inline bool folio_test_f2fs_##name(const struct folio *folio) \ > } \ > static inline bool page_private_##name(struct page *page) \ > { \ > - return PagePrivate(page) && \ > + return page_private(page) && \ > test_bit(PAGE_PRIVATE_NOT_POINTER, &page_private(page)) && \ > test_bit(PAGE_PRIVATE_##flagname, &page_private(page)); \ > } > @@ -2710,9 +2710,9 @@ static inline void folio_set_f2fs_##name(struct folio *folio) \ > } \ > static inline void set_page_private_##name(struct page *page) \ > { \ > - if (!PagePrivate(page)) \ > - attach_page_private(page, (void *)0); \ > - set_bit(PAGE_PRIVATE_NOT_POINTER, &page_private(page)); \ > + if (!page_private(page)) \ > + attach_page_private(page, \ > + (void *)BIT(PAGE_PRIVATE_NOT_POINTER)); \ > set_bit(PAGE_PRIVATE_##flagname, &page_private(page)); \ > } > > > -- > 2.53.0 > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel