All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanislav Kinsburskii <skinsburskii@gmail.com>
To: Paul Moore <paul@paul-moore.com>
Cc: Shuah Khan <shuah@kernel.org>, Eric Paris <eparis@redhat.com>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Amy Griffis <amy.griffis@hp.com>,
	Frank Hofmann <hofmann@deshaw.com>,
	Noah Orlando <orlandon@deshaw.com>,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	audit@vger.kernel.org
Subject: Re: [PATCH 1/3] selftests/audit: Add syscall overhead benchmark
Date: Thu, 3 Sep 2026 14:13:02 -0700	[thread overview]
Message-ID: <apni3p2JBQmc5IZQ@skinsburskii> (raw)
In-Reply-To: <580b5af8293cea8dc0a13e044b52280c@paul-moore.com>

On Tue, Sep 01, 2026 at 05:35:12PM -0400, Paul Moore wrote:
> On Aug  6, 2026 Stanislav Kinsburskii <skinsburskii@gmail.com> wrote:
> > 
> > Add a microbenchmark which repeatedly invokes getpid(2) and reports the
> > per-operation latency across multiple repetitions. The workload avoids
> > filesystem and other syscall-specific work so the fixed audit syscall
> > overhead remains visible.
> > 
> > The benchmark deliberately leaves audit policy management to the caller.
> > This permits comparisons with increasing numbers of unrelated exit rules
> > and with automatically removed watch or tree rules without modifying an
> > existing policy unexpectedly.
> > 
> > Signed-off-by: Stanislav Kinsburskii <skinsburskii@gmail.com>
> > ---
> >  MAINTAINERS                                 |   1 +
> >  tools/testing/selftests/Makefile            |   1 +
> >  tools/testing/selftests/audit/.gitignore    |   2 +
> >  tools/testing/selftests/audit/Makefile      |   9 ++
> >  tools/testing/selftests/audit/README        |  30 ++++
> >  tools/testing/selftests/audit/audit_bench.c | 227 ++++++++++++++++++++++++++++
> >  6 files changed, 270 insertions(+)
> 
> Thanks for this Stanislav, but I'm not certain that we want to merge this
> into the kernel and have this become the defacto standard for audit
> performance.  It's a simple, easy to understand test, but I worry that it
> might be too simplistic to properly characterize audit performance.
> 
> ... and no, I'm sorry, but I don't have a better suggestion off the top
> of my head :)
> 
> However, audit_bench might be useful as part of the manual_tests in the
> audit-testsuite?
> 
>  https://github.com/linux-audit/audit-testsuite
> 

Sure, here is a PR: https://github.com/linux-audit/audit-testsuite/pull/129

Thanks,
Stanislav

> --
> paul-moore.com

  reply	other threads:[~2026-09-03 21:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-07  1:01 [PATCH 0/3] audit: Measure and reduce syscall filtering overhead Stanislav Kinsburskii
2026-08-07  1:01 ` [PATCH 1/3] selftests/audit: Add syscall overhead benchmark Stanislav Kinsburskii
2026-09-01 21:35   ` Paul Moore
2026-09-03 21:13     ` Stanislav Kinsburskii [this message]
2026-08-07  1:01 ` [PATCH 2/3] audit: Fix filter rule accounting after automatic removal Stanislav Kinsburskii
2026-09-01 21:35   ` Paul Moore
2026-08-07  1:01 ` [PATCH 3/3] audit: Skip exit filtering for syscalls without rules Stanislav Kinsburskii
2026-09-01 21:35   ` Paul Moore
2026-09-03 16:37     ` Stanislav Kinsburskii
2026-08-23 18:10 ` [PATCH 0/3] audit: Measure and reduce syscall filtering overhead Stanislav Kinsburskii
2026-08-25  1:56   ` Paul Moore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=apni3p2JBQmc5IZQ@skinsburskii \
    --to=skinsburskii@gmail.com \
    --cc=amy.griffis@hp.com \
    --cc=audit@vger.kernel.org \
    --cc=eparis@redhat.com \
    --cc=hofmann@deshaw.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=orlandon@deshaw.com \
    --cc=paul@paul-moore.com \
    --cc=shuah@kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.