From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Benson Leung <bleung@chromium.org>
Cc: chrome-platform@lists.linux.dev
Subject: Re: [PATCH] platform/chrome: cros_ec_proto: Simplify cros_ec_wait_until_complete()
Date: Fri, 4 Sep 2026 07:56:33 +0000 [thread overview]
Message-ID: <app5sZPTYDAodBlT@google.com> (raw)
In-Reply-To: <20260902100651.274749-1-tzungbi@kernel.org>
On Wed, Sep 02, 2026 at 10:06:51AM +0000, Tzung-Bi Shih wrote:
> There is no need to defer the return out of the loop. Replace the
> `break` with an immediate `return -EPROTO`.
>
> With the `break` removed, execution only reaches the end of the function
> if it exhausts all EC_COMMAND_RETRIES. The post-loop check is therefore
> redundant and replaced with an unconditional `return -EAGAIN`.
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next
[1/1] platform/chrome: cros_ec_proto: Simplify cros_ec_wait_until_complete()
commit: 7b6344a49cf5fed1879ee5c125d01a2535fbd725
Thanks!
prev parent reply other threads:[~2026-09-04 7:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 10:06 [PATCH] platform/chrome: cros_ec_proto: Simplify cros_ec_wait_until_complete() Tzung-Bi Shih
2026-09-04 7:56 ` Tzung-Bi Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=app5sZPTYDAodBlT@google.com \
--to=tzungbi@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.