From: Ratheesh Kannoth <rkannoth@marvell.com>
To: <netdev-bot+sashiko@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<andrew+netdev@lunn.ch>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<sgoutham@marvell.com>, <hkelam@marvell.com>
Subject: Re: [PATCH net-next] octeontx2-pf: report port connector type in ethtool link ksettings
Date: Fri, 4 Sep 2026 14:31:23 +0530 [thread overview]
Message-ID: <apqI44Y5ooLOPeij@rkannoth-OptiPlex-7090> (raw)
In-Reply-To: <178850876430.4131868.17635457333077226877@kernel.org>
On 2026-09-04 at 13:29:24, netdev-bot+sashiko@kernel.org (netdev-bot+sashiko@kernel.org) wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue(s) to consider:
>
> Critical: 0 · High: 0 · Medium: 1 · Low: 0
>
> - [Medium] otx2_get_link_ksettings()
> (drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c:1235)…
>
> --
>
> octeontx2-pf: report port connector type in ethtool link ksettings
> Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260901045857.2779326-1-rkannoth%40marvell.com
i think, below sole issue can be ignored.
+---+----------+--------+----------------------+---------------------------------------------------+
| # | Severity | Status | Location | Issue |
+===+==========+========+======================+===================================================+
| 1 | Medium | New | otx2_get_link_ksettin| Raw rsp->fwdata.port (u64 firmware field) is |
| | | | s() | assigned directly to cmd->base.port (__u8 ethtool |
| | | | drivers/net/ethernet/| PORT_* field) with no translation, bounds check, o|
| | | | arvell/octeontx2/nic/| validity gate. |
| | | | tx2_ethtool.c:1235 | |
+---+----------+--------+----------------------+---------------------------------------------------+
next prev parent reply other threads:[~2026-09-04 9:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 4:58 [PATCH net-next] octeontx2-pf: report port connector type in ethtool link ksettings Ratheesh Kannoth
2026-09-04 7:59 ` netdev-bot+sashiko
2026-09-04 9:01 ` Ratheesh Kannoth [this message]
2026-09-04 12:30 ` Simon Horman
2026-09-04 22:48 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apqI44Y5ooLOPeij@rkannoth-OptiPlex-7090 \
--to=rkannoth@marvell.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkelam@marvell.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.