From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D0CA3A48F6 for ; Fri, 4 Sep 2026 10:30:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788517817; cv=none; b=JiYESnrcTJyZSksiLuEAZSoFUxm7lkSUAos/70rpwHA9jylBlBtEOJzTKg/QQy2+w2I8ddWea9CsgpGD10gRsLotgV+Z3/4GUXRtlzNsNxwHUCL7OqDg+/e6CVoY5pUa21EQo0BLpMZoHVJCwCqRRyxiUYsLAW5kiElBwUvzbGQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788517817; c=relaxed/simple; bh=uVc0Haysmuy6CvaFK+dk8qOhVOt4yNfT0/lEf2bvims=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=k7cFVGizzDSiMG4d6hPmJ8pK7Kv3K9xjikUF81tZihNPoTWugjw0RBtiuLBiJ6PJGjGMY4hLPw8zCowBbHhj2QvPKoa82rK31eOTL4UzVbuUUtmKoGNCXynVNN8J1f0nNM74xjop8IIqd4S+T0EzbxxNaWuRwsT1smo63VrDVEA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=b/ki3fYX; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="b/ki3fYX" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-498028b3d5eso7816715e9.1 for ; Fri, 04 Sep 2026 03:30:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1788517813; x=1789122613; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:date:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=cZQTL/pBpcVt07rJQmd4UdoWGK2B3BL5sj1p+ycgeVo=; b=b/ki3fYX1t4yYV2hW8vSywi+rFbVqvfkl3hGMS7ftZIqHJXy9ZK5aRpwnKVufeNMpK MD/DhW95IebR0eL7lFV3SDPM8/d5jJYcTTGCyJnV/6pH0AaUQnQszjBjIWEtLrlsZacN A5A2reM7wGWkjU9HRfFKkri+P9MZeuOdT1GspZSUmQIJ8juywrjEmS31uIze6HyCi+9Q ng5mQtElxqNxqkjSW8OGBEoBg8WpWFxJSFK8MAnL6oBxzV/Jd1TBIuEy0swwyUYZcB5t TRblCNqaCOaLV1H7TMXi/UVyHm742YZMqPsvkUUiKr8n9e0jrfh0s0RlNn9CMMU3LnbT sfkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788517813; x=1789122613; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=cZQTL/pBpcVt07rJQmd4UdoWGK2B3BL5sj1p+ycgeVo=; b=nAcYyWBB/CGSgSyUrSsluXhoQGqBkjjjUpEiwxdigDp0ZCeuCsGQbBlYkqFOebxfU3 lfLzPD+b1K2pAs9H5R4KsVckvKLWAHvfRgDiBgvzm1CZQx7dRGn9Ztj/bhgiAgPh71zr BwxPytcVf80M4kS+dbqggq+y69aoKETwGa3P/magrAxhuYXliH1w7IidL40cdEMDnHQ1 f7xPJLHdLycSrBFCdwenFRWklW8r+gTcJZIl5HxP9mXGwW1dmh3fZ+96+jJa4o//htAF WC5nusYTe4rbZxYgj/xzkhOawyg/xi//LP7ggXWkWeVCToCU94MWLg3CcImmQ7N7yFxe Of2Q== X-Forwarded-Encrypted: i=1; AKwUvBxFQaZcfuhsjSBl5VC6/znqoLHrShPWqmAb2OoTIJd77n7tG+rOGwT4cilSYzU1I9sVY99aMGxsA3CU@vger.kernel.org X-Gm-Message-State: AFuF++mAmC5GSy2yM8/1jEVBNDUqClyJcvn3D6QoE0X/57okrCCLIroq auCMu8o9stwPhdy/gfbXShpuIbSn6s6f9psgJWzjHLR6vrubxcn/FEqauAZ1EMKvDUQ= X-Gm-Gg: AYBFou3scwpQlw5tpivtwL/F1cVbclPndEYceRpkCsA9d5q27u2tYv4ZSfNsrtugiyd Jj4UacNx99cXz+5MxNMI0dvtevYBqhUHLRmIA1UtMEoonUkJJZ2zyj6eUQVKgYbaMjYXURK8Gqj GaZEZ0VjhM9UtVScduip7gxfhr9BBhKHlakccw8hKc0qD4JRxnJgrMkQWbhdx21i5B45gdJegxc mxdm4zg7a4fr1rWLm31EAHFnvrQ9bBPbiPLIztehXPtatWKiat4rAy9tqjR0Z2G9aAoFdh6UqO4 x4RoUQVtp1J278rd5XEfngVplgfWszTVksPfgng6BMgM1lpVePdYRFeAtKIJM7fOcZMvBkoR9z0 6tNrE9w6hEHTCMq+f4f4/ZroE0wVTqprtQNlPNNl4Gvf9pyGUlxFiEFroMFLkLJGM+JrOJt12LF GbAE1XmTsRIE8epye0YDY29ymMLBk45xSsI8eUUx1+lm5nsd6ewK8I+fKkQw== X-Received: by 2002:a05:600c:8708:b0:49c:fa21:1c7c with SMTP id 5b1f17b1804b1-49cfa211d48mr27435135e9.17.1788517813094; Fri, 04 Sep 2026 03:30:13 -0700 (PDT) Received: from localhost ([194.183.24.73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-485883c5bc5sm5567744f8f.24.2026.09.04.03.30.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Sep 2026 03:30:12 -0700 (PDT) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Fri, 4 Sep 2026 12:33:51 +0200 To: Gregor Herburger Cc: Andrea della Porta , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2] arm64: dts: broadcom: bcm2712-rpi-5-b: add spi0 interface Message-ID: References: <20260904-bcm2712-spi-v2-1-6f8fdfb030bc@linutronix.de> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260904-bcm2712-spi-v2-1-6f8fdfb030bc@linutronix.de> Hi Gregor, On 11:24 Fri 04 Sep , Gregor Herburger wrote: > The Raspberry Pi 5 routes the spi0 of the rp1 chip to the pin header. > Add the rp1_spi0 node and its pinctrl node to the devicetree to enable > the spi interface. Just a nit-pick: in the comment it's stated that the spi interface is enabled, which is not true since rp1_usb inherit status="disabled" from its node definition. This is fine because the user would probably want to enable the spi interface through some overlay, so no need to resend the patch (at least for me), so: Reviewed-by: Andrea della Porta Thanks! Andrea > > Signed-off-by: Gregor Herburger > --- > The RP1 chip, found on the raspberry Pi 5, has nine spi controllers. The > spi0 is routed to the pin header. Add the rp1 nodes and enable it for > the Raspberry Pi 5. > --- > Changes in v2: > - Drop first patch as it got already applied: https://lore.kernel.org/lkml/20260903194624.2038562-1-florian.fainelli@broadcom.com/ > - add cs gpios to rp1_gpio for pinctrl > - Link to v1: https://patch.msgid.link/20260811-bcm2712-spi-v1-0-4c1708d354bb@linutronix.de > --- > arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts > index 0fc57e72632ed..0de3d78100a5d 100644 > --- a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts > +++ b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts > @@ -69,6 +69,20 @@ usb_vbus_default_state: usb-vbus-default-state { > groups = "vbus1"; > }; > > + rp1_spi0_default_state: rp1-spi0-default-state { > + function = "spi0"; > + groups = "spi0"; > + bias-disable; > + drive-strength = <12>; > + slew-rate = <1>; > + }; > + > + rp1_spi0_cs_default_state: rp1-spi0-cs-default-state { > + function = "gpio"; > + pins = "gpio7", "gpio8"; > + bias-pull-up; > + }; > + > rp1_i2c4_default_state: rp1-i2c4-default-state { > function = "i2c4"; > groups = "i2c4_2"; > @@ -94,6 +108,14 @@ &rp1_i2c6 { > pinctrl-names = "default"; > }; > > +&rp1_spi0 { > + pinctrl-0 = <&rp1_spi0_default_state &rp1_spi0_cs_default_state>; > + pinctrl-names = "default"; > + > + num-cs = <2>; > + cs-gpios = <&rp1_gpio 8 GPIO_ACTIVE_LOW &rp1_gpio 7 GPIO_ACTIVE_LOW>; > +}; > + > &rp1_usb0 { > pinctrl-0 = <&usb_vbus_default_state>; > pinctrl-names = "default"; > > --- > base-commit: db2ddb87143519e20a95aa36c60b36107b736a58 > change-id: 20260811-bcm2712-spi-644b70fee3bf > > Best regards, > -- > Gregor Herburger >