All of lore.kernel.org
 help / color / mirror / Atom feed
From: Karl Mehltretter <kmehltretter@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>,
	 Rich Felker <dalias@libc.org>,
	John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
	 linux-sh@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 1/2] sh: Drop the selects of the removed CONFIG_USB_OHCI_SH symbol
Date: Sat, 5 Sep 2026 17:06:33 +0200	[thread overview]
Message-ID: <apwufhbG44hRsNWm@gmail.com> (raw)
In-Reply-To: <CAMuHMdWYBp0d7m0Q8rWva+EA=4nOezm1os_6ZVcrh43aPjCCPQ@mail.gmail.com>

On Sat, Sep 05, 2026 at 03:55:57PM +0100, Geert Uytterhoeven wrote:
> >         select CPU_HAS_DSP
> >         select SYS_SUPPORTS_SH_CMT
> > -       select USB_OHCI_SH if USB_OHCI_HCD
> 
> This is wrong, it should select USB_OHCI_HCD_PLATFORM instead.
> Someone has already sent a patch for that[1], so it would be great if
> that could be picked up instead.
> 
> [1] "[PATCH] sh: Use generic OHCI platform provider symbol"
>     https://lore.kernel.org/20260624081926.12426-1-pengpeng@iscas.ac.cn/
> 

Yes my patch is not "wrong" (doesn't make things worse) but clearly this 
is the proper solution.

So please consider both patches of this series withdrawn, the
defconfig change in 2/2 is covered by Pengpeng's patch as well.

I have resent Pengpeng's patch as v2 with his authorship kept:

https://lore.kernel.org/r/20260905145225.88518-1-kmehltretter@gmail.com/

Thanks,
Karl

  reply	other threads:[~2026-09-05 15:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-05  6:53 [PATCH 0/2] sh: Drop the leftovers of the removed CONFIG_USB_OHCI_SH Karl Mehltretter
2026-09-05  6:53 ` [PATCH 1/2] sh: Drop the selects of the removed CONFIG_USB_OHCI_SH symbol Karl Mehltretter
2026-09-05 13:55   ` Geert Uytterhoeven
2026-09-05 15:06     ` Karl Mehltretter [this message]
2026-09-05  6:53 ` [PATCH 2/2] sh: configs: Drop CONFIG_USB_OHCI_SH from sh7757lcr_defconfig Karl Mehltretter
2026-09-05 15:11 ` [PATCH 0/2] sh: Drop the leftovers of the removed CONFIG_USB_OHCI_SH Karl Mehltretter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=apwufhbG44hRsNWm@gmail.com \
    --to=kmehltretter@gmail.com \
    --cc=dalias@libc.org \
    --cc=geert@linux-m68k.org \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.