From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B652F396D15 for ; Sat, 5 Sep 2026 22:25:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788647129; cv=none; b=jsSBTc2FS2LevISyXvjklCwaYs5tYEj3gebzDFZEetB2eAAFYR20U2RyxpfC4iynHIEXK+g4Q9seBupCiSZcy7V17XbA8KW/8X5aqmVuc3DBpAEL4gMEvq4KlO7Orb4D+p/DZfeReNSP70GUT7LsZpyPfhTLnuMqXE2Kde4A16o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788647129; c=relaxed/simple; bh=ngl+xzOiaCR8FkeiD4BZS6Ct3WMCnpj/FpxmjdQvCcE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JrI1jS/q1qD0gaKQw94+tYp+yV2cTm5hR3nOEGtLlINVTuzn73WfYOMXcA+/zbkflx369kkSrTcjdeh4jKl42kEdmeTxwtjQS/HibFza08B2LrG4EQ5F1ZS176BLDQ9ZuPoji0fvGfsSfzOGE5yrElBVaPQUV/6RZ6TbUTl1nE0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Yko1n5Vv; arc=none smtp.client-ip=209.85.167.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Yko1n5Vv" Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-5b0231a3e86so1961978e87.0 for ; Sat, 05 Sep 2026 15:25:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788647125; x=1789251925; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=up7v4iXfsfw0NZXjJnHOv6nLKWdrBroAhEtbXWzurTc=; b=Yko1n5Vv/Tc2A8zdvPoBbgp6SM8eBEIkWYOuDzAz4fSY67/fu392y7t5MA6R1EKGNF SK+FwkqXQUY9AVomM4tlte/H3OIWCPIIzU1UIcKgKqVBMnkqTT6ZvHbJ66T4bKcg6HO2 0G+gTtr9X/39aTY9oErNXoqw/AVrX0c1K1YG1c+8wZH3Si0bZHhvA6TUb5VAMZq1CRsd QsgbhgJ+U7n+TD4ayL5W2+I062w5aoIaZ5SA/PB2fNNa91csnCdlMnzZ6C9bTOmg/Tno 2L7P7VG5ybCWRDa81o46+WzLzOTx/WwJI0rNHxUOplNjZ6hBdjo9h2+FXRmXMGWvEQTs 7TNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788647125; x=1789251925; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=up7v4iXfsfw0NZXjJnHOv6nLKWdrBroAhEtbXWzurTc=; b=T0m7cWyepgiDHfW2KCuWICdy8XYIjGAWA8qX7Zccu1Ut2h+NSIg6gVFvDj9bhrjT3t JwfTI2/c8G7d55CVJtiBpw+VnNE5zZwSDiiTLB3VMbj6UqtOST70pmX+pZLjLyfnZUhJ DrdkfqB7Utz0JUsD5Vb5t9NIm7xWX0hleXGakn2rTkUVRk0KHaWG0kd5MHz+o1m/xWGr WuWtaTB5QxLL6ztCsSIBTdRsEhbWDFa2jEHu/u/cOz08oc1OkEVWJV/NQdYStb4IaLf2 3D6cvSWbt740Ti6z+qOMPVpYJPaODOlcnNfVhwdOXnfSRaD/jCe7TowLMr5sFdPopzG4 OIDA== X-Forwarded-Encrypted: i=1; AKwUvBwuKUBnmEo1SUrI96rVSNBuV/OWAW8xIUNuk7plhP0V7DSFAOU9TfHAlH1/u63hAAtSV94bxQNzz95I@vger.kernel.org X-Gm-Message-State: AFuF++nTMJKH9svCV24W3auNKgBTLO0XyrGWxqb3IouPA3P4ZVxktLg2 RHqtK5aQT7rKJQn0sLD+BOXM3Q3imy2j6CR2QzBOoe3u0P0V9t+WTxVAssUp0HB+ X-Gm-Gg: AYBFou1llSb3SvsAUXu0/ln8ZC+NUPYX2p8Jcgi6geTUdNuI1nB6awFfaxlC6Bx22Ve qtysmg0EEGFQT/APh5pQvls9n+irCvqkGFD4YAU+lmOkVw/30QTAIicDIWjDda11JSP1+bgQqFd KBOFpzv7RIzhC400uhtasYrL8Mxdbjwtv8p7RNYzXbCypYMb9UMkgJEI27H3UTUG8vsnx6xRtUO guKmcIoLvBzM1YbA2V3eW6++OvAisYHzOz97PwqODfMWi85IB/oQ22UEJMEYyFKIiKSyNWGs4Kg DybTUymG/Y8qjSxq8gcWKBY2QIHtXExJgS6vxUyp9Z23R/u5XQKotqXIFib5TAClFMIXDA1aB/8 dlITj42nCY3AnGc21S4PH+ox0M6o1emi27PdEp1BroME3hWqwdRR/gQWyxauvE7CDN/s6WkVyBA BOWlxmGYJ+71ohGju/6E1/pZxgKqp01f+4IWtlQZoc9AtMIjk7NKCCp7LiGSZDVaNFN0qYWeGew dBX X-Received: by 2002:a05:6512:3503:b0:5b5:e8d5:7fff with SMTP id 2adb3069b0e04-5b616f0ba95mr2232510e87.8.1788647125226; Sat, 05 Sep 2026 15:25:25 -0700 (PDT) Received: from localhost (soda.int.kasm.eu. [2001:678:a5c:1202:7b92:9ac1:b9ef:5287]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b6166f6c00sm1299495e87.35.2026.09.05.15.25.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Sep 2026 15:25:24 -0700 (PDT) Date: Sun, 6 Sep 2026 00:25:24 +0200 From: Klara Modin To: Manuel Ebner Cc: Thorsten Leemhuis , Alex Deucher , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Felix.Kuehling@amd.com, Mukul Joshi , Christian =?utf-8?B?S8O2bmln?= , Mark Brown , Miguel Ojeda , rust-for-linux@vger.kernel.org, Linux Next Mailing List Subject: Re: [PATCH 1/3] drm/gem: Add callback for when handle count goes to 0 Message-ID: References: <20260831183311.1090131-1-alexander.deucher@amd.com> <20260831183311.1090131-2-alexander.deucher@amd.com> Precedence: bulk X-Mailing-List: linux-next@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On 2026-09-05 11:31:41 +0200, Manuel Ebner wrote: > On Sat, 2026-09-05 at 07:36 +0200, Thorsten Leemhuis wrote: > > On 8/31/26 20:33, Alex Deucher wrote: > > > From: Mukul Joshi > > > ... > > ... > > > > > > error[E0063]: missing field `handle_free` in initializer of `drm_gem_object_funcs` > > > >    --> rust/kernel/drm/gem/mod.rs:265:58 > > > >     | > > > > 265 |     const OBJECT_FUNCS: bindings::drm_gem_object_funcs = bindings::drm_gem_object_funcs { > > > >     |                                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `handle_free` > > > > > > > > error: aborting due to 1 previous error > > > > > > > > For more information about this error, try `rustc --explain E0063`. > > > > make[2]: *** [rust/Makefile:799: rust/kernel.o] Error 1 > > > > make[1]: *** [/builddir/build/BUILD/kernel-7.3.0-build/kernel-next-20260904/linux-7.3.0-0.0.next.20260904.221.vanilla.fc43.aarch64/Makefile:1442: prepare] Error 2 > > > > make: *** [Makefile:256: __sub-make] Error 2 > > """ > > Full log: > > https://download.copr.fedorainfracloud.org/results/@kernel-vanilla/next/fedora-43-aarch64/10951622-next-next-all/builder-live.log.gz > > > > Reverting this change and 2/3 from this set fixed the problem for me. That leaves only the documentation without the feature so might as well drop 3/3 too in that case? Otherwise, the following also fixes it for me: diff --git a/rust/kernel/drm/gem/mod.rs b/rust/kernel/drm/gem/mod.rs index e1ebad77ebe2..847e0ee38863 100644 --- a/rust/kernel/drm/gem/mod.rs +++ b/rust/kernel/drm/gem/mod.rs @@ -278,6 +278,7 @@ impl Object { vm_ops: core::ptr::null_mut(), evict: None, rss: None, + handle_free: None, }; /// Returns the `Device` that owns this GEM object. > > Verified. > > Thanks > Manuel > > > > Ciao, Thorsten > > > ... Regards, Klara Modin