From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: Luca Weiss <luca.weiss@fairphone.com>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Jessica Zhang <jesszhan0024@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>,
Simona Vetter <simona@ffwll.ch>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, dri-devel@lists.freedesktop.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2 2/4] drm/panel: Add driver for Novatek NT37705 panel
Date: Fri, 18 Sep 2026 17:58:42 +0200 [thread overview]
Message-ID: <aq1erjmXLCFB3uoB@monoceros> (raw)
In-Reply-To: <20260918-fp6-panel-v2-2-6695c4008920@fairphone.com>
[-- Attachment #1: Type: text/plain, Size: 500 bytes --]
On Fri, Sep 18, 2026 at 04:40:05PM +0200, Luca Weiss wrote:
> +#include <linux/mod_devicetable.h>
Please don't include that file. of_device_id is also provided by
<drm/drm_mipi_dsi.h> (transitively via <linux/device.h> ->
<linux/device/driver.h> -> <linux/device-id/of.h>) and you can rely on
that.
If you want to go full iwyu, please use <linux/device-id/of.h> instead
of <linux/mod_devicetable.h>.
<linux/mod_devicetable.h> is a dependency hog and will hopefully go away
soon.
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-09-18 15:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 14:40 [PATCH v2 0/4] Add Novatek NT37705 panel driver for Fairphone (Gen. 6) Luca Weiss
2026-09-18 14:40 ` [PATCH v2 1/4] dt-bindings: display: panel: Add Novatek NT37705 Luca Weiss
2026-09-18 14:51 ` sashiko-bot
2026-09-18 21:35 ` Rob Herring
2026-10-02 14:00 ` Luca Weiss
2026-10-02 14:16 ` Rob Herring
2026-09-18 14:40 ` [PATCH v2 2/4] drm/panel: Add driver for Novatek NT37705 panel Luca Weiss
2026-09-18 14:58 ` sashiko-bot
2026-09-18 15:58 ` Uwe Kleine-König [this message]
2026-10-05 6:55 ` Dmitry Baryshkov
2026-09-18 14:40 ` [PATCH v2 3/4] arm64: defconfig: Enable " Luca Weiss
2026-09-18 14:40 ` [PATCH v2 4/4] arm64: dts: qcom: milos-fairphone-fp6: Enable display Luca Weiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aq1erjmXLCFB3uoB@monoceros \
--to=u.kleine-koenig@baylibre.com \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.