Re: [Buildroot] [PATCH] package/mali-t76x: add missing license information

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Sebastian Michel <sebastian.michel@oss.othermo.de>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/mali-t76x: add missing license information
Date: Fri, 18 Sep 2026 22:27:23 +0200	[thread overview]
Message-ID: <aq2eM8i4IYzeoV9B@windsurf> (raw)
In-Reply-To: <20260825073605.68465-1-sebastian.michel@oss.othermo.de>

On Tue, Aug 25, 2026 at 09:36:05AM +0200, Sebastian Michel wrote:
> Added MALI_T76X_STRIP_COMPONENTS = 0 as tar archive follows nonstandard layout with license file being in the topmost directory
> 
> Signed-off-by: Sebastian Michel <sebastian.michel@oss.othermo.de>
> ---
>  package/mali-t76x/mali-t76x.hash | 1 +
>  package/mali-t76x/mali-t76x.mk   | 9 +++++++--
>  2 files changed, 8 insertions(+), 2 deletions(-)

Thanks for your patch. I've applied (after doing minor changes, see
below).

One question though: are you actually using this package?

Indeed, its upstream site is dead:

Failed to resolve 'malideveloper.arm.com' (Name or service not known)
Failed to connect: Connect error

so we're always falling back to the backup copy on
sources.buildroot.net.

> diff --git a/package/mali-t76x/mali-t76x.hash b/package/mali-t76x/mali-t76x.hash
> index a754b98074..751d0e7bf2 100644
> --- a/package/mali-t76x/mali-t76x.hash
> +++ b/package/mali-t76x/mali-t76x.hash
> @@ -1,2 +1,3 @@
>  # Locally computed:
>  sha256  5a0b00438edc8066b374481d3332a43c07ec2bd3bc73265983a968970f754902  mali-t76x_r5p0-06rel0_linux_1+fbdev.tar.gz
> +sha256  b0ca7cedaf4f604a1c863ea71f741d6ca1474aebac7e606ec43d725b3c74cc63  END_USER_LICENCE_AGREEMENT.txt
> \ No newline at end of file

This lack of newline was causing a check-package warning:

WARNING: package/mali-t76x/mali-t76x.hash:3: missing newline at end of file

> diff --git a/package/mali-t76x/mali-t76x.mk b/package/mali-t76x/mali-t76x.mk
> index 387685c033..05d7d4812c 100644
> --- a/package/mali-t76x/mali-t76x.mk
> +++ b/package/mali-t76x/mali-t76x.mk
> @@ -10,9 +10,14 @@ MALI_T76X_SITE = http://malideveloper.arm.com/downloads/drivers/binary/$(MALI_T7
>  MALI_T76X_DEPENDENCIES = mesa3d-headers
>  MALI_T76X_INSTALL_STAGING = YES
>  MALI_T76X_PROVIDES = libegl libgles
> +MALI_T76X_LICENSE = ARM Mali GPU EULA (LES-PRE-20376)

The (LES-PRE-20376) information seemed pretty useless (not
informative), so I dropped it. Did you have a specific reason to
include it?

> +MALI_T76X_LICENSE_FILES = END_USER_LICENCE_AGREEMENT.txt
> +MALI_T76X_REDISTRIBUTE = NO
> +MALI_T76X_STRIP_COMPONENTS = 0
> +
>

These two consecutive newlines caused the following check-package
warning:

WARNING: package/mali-t76x/mali-t76x.mk:18: consecutive empty lines

Applied with those issues fixed. Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot