All of lore.kernel.org
 help / color / mirror / Atom feed
From: Uladzislau Rezki <urezki@gmail.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
	Uladzislau Rezki <urezki@gmail.com>
Subject: Re: [PATCH] mm/vmalloc: Use %p for pointer formatting
Date: Sat, 19 Sep 2026 09:23:36 +0200	[thread overview]
Message-ID: <aq44eOsUuWb6fD43@pc636> (raw)
In-Reply-To: <20260919003934.86889-1-sj@kernel.org>

On Fri, Sep 18, 2026 at 05:39:33PM -0700, SJ Park wrote:
> On Fri, 18 Sep 2026 12:50:13 +0200 Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
> 
> > Commit 45ec16908e84e ("mm: use %pK for /proc/vmallocinfo") introduced
> > the %pK in order not to leak kernel pointers.
> > Since commit ad67b74d2469d ("printk: hash addresses printed with
> > %p") pointers are hashed by default and the behaviour can be controller
> 
> s/controller/controlled/ ?
> 
> > by `hash_pointers' boot argument.
> > The policy on %p is to not introduce new ones.
> > Removing %pK makes it possible to remove its handling from the library.
> > 
> > Looking at the output, having the pointer in the output makes it
> > possible to distinguish the individual entries.
> > 
> > Use %p instead %pK.
> 
> Makes sense to me.
> 
> > 
> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> 
> Reviewed-by: SJ Park <sj@kernel.org>
> 
Reviewed-by: Uladzislau Rezki (Sony) <urezki@gmail.com>

--
Uladzislau Rezki


      reply	other threads:[~2026-09-19  7:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-18 10:50 [PATCH] mm/vmalloc: Use %p for pointer formatting Sebastian Andrzej Siewior
2026-09-18 20:05 ` Andrew Morton
2026-09-18 20:14   ` Sebastian Andrzej Siewior
2026-09-19  0:39 ` SJ Park
2026-09-19  7:23   ` Uladzislau Rezki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aq44eOsUuWb6fD43@pc636 \
    --to=urezki@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=bigeasy@linutronix.de \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.