Re: [PATCH v2] man/man7/inotify.7: Fix typo in struct size calculation

[Alejandro Colomar <alx@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1997 bytes --]

Hi Maxim,

> Date: 2026-09-18 23:05:58-0700
> From: Maxim Inozemtsev <milnadar@gmail.com>
>
> I like your corrections.
> Please see my sign-off for this patch below:
> 
> Signed-off by: Maxim Inozemtsev <milnadar@gmail.com>

Thanks!

I had pushed the patch already some days ago, so I can't append your
signature, but still thanks!  I'll remain here in the list.  :)


Have a lovely day!
Alex

> 
> Thank you,
> Maxim
> 
> On Thu, Sep 10, 2026 at 4:17 PM Alejandro Colomar <alx@kernel.org> wrote:
> >
> > From: Maxim Inozemtsev <milnadar@gmail.com>
> >
> > Fixes: 18e7c4597c4e (2024-11-17; "man/: Terminology consistency reforms (n, size, length)")
> > Co-authored-by: Maxim Inozemtsev <milnadar@gmail.com>
> > Message-ID: <CAE8uRQ1WhW=5X-zCCi4g9y4s-rEYdmY_=2o4Re1thKyijV3RXw@mail.gmail.com>
> > Signed-off-by: Alejandro Colomar <alx@kernel.org>
> > ---
> >
> > Hi Maxim,
> >
> > I've slightly modified your patch, to be more correct, and show that
> > 'len' isn't just a variable, but a structure member.
> >
> > Do you like this patch?  If so, would you mind signing it?
> > <https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by>
> >
> >
> > Have a lovely night!
> > Alex
> >
> >  man/man7/inotify.7 | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/man/man7/inotify.7 b/man/man7/inotify.7
> > index 9575b82e7ffb..dcdf95d0665c 100644
> > --- a/man/man7/inotify.7
> > +++ b/man/man7/inotify.7
> > @@ -137,7 +137,7 @@ .SS Reading events from an inotify file descriptor
> >  the size of each
> >  .I inotify_event
> >  structure is thus
> > -.IR "sizeof(struct inotify_event)+size" .
> > +.IR sizeof(struct\~inotify_event)\~+\~event.len .
> >  .P
> >  The behavior when the buffer given to
> >  .BR read (2)
> >
> > base-commit: 93337ae940c227db2b4a6141268a41b222df4283
> > --
> > 2.55.0
> >
> 

-- 
<https://www.alejandro-colomar.es>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]