Re: [PATCH v6] ata: ahci_da850: switch to DEFINE_SIMPLE_DEV_PM_OPS

[Niklas Cassel <cassel@kernel.org>]

Hello Li Jun,

On Tue, Sep 08, 2026 at 08:50:29PM +0800, Li Jun wrote:
> Replace the deprecated SIMPLE_DEV_PM_OPS macro with the recommended
> DEFINE_SIMPLE_DEV_PM_OPS. Use pm_sleep_ptr(&ahci_da850_pm_ops) to complete
> the API migration and allow the structure to be correctly dropped
> when CONFIG_PM_SLEEP=n.
> 
> Signed-off-by: Li Jun <lijun01@kylinos.cn>
> Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
> ---
> changelogs:
> -add pm_ptr for ahci_da850_pm_ops in ahci_da850_driver.
> -revise grammar and alignment issues.
> -Align parentheses.
> -change pm_ptr to pm_sleep_ptr.
> -Modify pm_ptr\CONFIG_PM to pm_sleep_ptr\CONFIG_PM_SLEEP in commit
> message.
> ---
>  drivers/ata/ahci_da850.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/ata/ahci_da850.c b/drivers/ata/ahci_da850.c
> index 4e53ff96d712..59b9ca26fd44 100644
> --- a/drivers/ata/ahci_da850.c
> +++ b/drivers/ata/ahci_da850.c
> @@ -218,8 +218,8 @@ static int ahci_da850_probe(struct platform_device *pdev)
>  	return rc;
>  }
>  
> -static SIMPLE_DEV_PM_OPS(ahci_da850_pm_ops, ahci_platform_suspend,
> -			 ahci_platform_resume);
> +static DEFINE_SIMPLE_DEV_PM_OPS(ahci_da850_pm_ops, ahci_platform_suspend,
> +				ahci_platform_resume);
>  
>  static const struct of_device_id ahci_da850_of_match[] = {
>  	{ .compatible = "ti,da850-ahci", },
> @@ -233,7 +233,7 @@ static struct platform_driver ahci_da850_driver = {
>  	.driver = {
>  		.name = DRV_NAME,
>  		.of_match_table = ahci_da850_of_match,
> -		.pm = &ahci_da850_pm_ops,
> +		.pm = pm_sleep_ptr(&ahci_da850_pm_ops),
>  	},
>  };
>  module_platform_driver(ahci_da850_driver);
> -- 
> 2.25.1
> 

I fixed up the commit message when applying your v5:
https://git.kernel.org/pub/scm/linux/kernel/git/libata/linux.git/commit/?id=f091e60fc986eb12ff632f682848b88da824bccb

So there was no need to send a v6 :)

Thank you for your contribution!


Kind regards,
Niklas