From: John Levon <john.levon@nutanix.com>
To: Hugo Komatsu <hugo.komatsu@nutanix.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"qemu-s390x@nongnu.org" <qemu-s390x@nongnu.org>,
"Alex Williamson" <alex@shazbot.org>,
"Cédric Le Goater" <clg@redhat.com>,
"Cornelia Huck" <cohuck@redhat.com>,
"Eric Farman" <farman@linux.ibm.com>,
"Halil Pasic" <pasic@linux.ibm.com>,
"Jason Herne" <jjherne@linux.ibm.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Matthew Rosato" <mjrosato@linux.ibm.com>,
"Pierrick Bouvier" <pierrick.bouvier@oss.qualcomm.com>,
"Rafael Castillo" <rafael@trfs.me>,
"Thanos Makatos" <thanos.makatos@nutanix.com>,
"Tony Krowiak" <akrowiak@linux.ibm.com>
Subject: Re: [PATCH 5/8] vfio: use io_ops abstraction for migration related ioctls
Date: Tue, 8 Sep 2026 15:47:48 +0100 [thread overview]
Message-ID: <aqAgFCuaJeqkCQ6e@lent> (raw)
In-Reply-To: <20260903130833.1437632-6-hugo.komatsu@nutanix.com>
On Thu, Sep 03, 2026 at 02:08:47PM +0100, Hugo Komatsu wrote:
> @@ -247,10 +247,9 @@ vfio_migration_set_state_or_reset(VFIODevice *vbasedev,
> static int vfio_load_buffer(QEMUFile *f, VFIODevice *vbasedev,
> uint64_t data_size)
> {
> - VFIOMigration *migration = vbasedev->migration;
> int ret;
>
> - ret = qemu_file_get_to_fd(f, migration->data_fd, data_size);
> + ret = vbasedev->io_ops->mig_data_write_from_file(vbasedev, f, data_size);
I'm guessing Cédric will want the wrapper functions for all of these too;
otherwise, LGTM.
regards
john
next prev parent reply other threads:[~2026-09-08 14:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 13:08 [PATCH 0/8] vfio-user: live migration support Hugo Komatsu
2026-09-03 13:08 ` [PATCH 1/8] vfio-user: add live migration to vfio-user protocol specification Hugo Komatsu
2026-09-08 14:41 ` John Levon
2026-09-03 13:08 ` [PATCH 2/8] docs/vfio-user: clarify data_fd and DMA logging behaviors Hugo Komatsu
2026-09-08 14:42 ` John Levon
2026-09-03 13:08 ` [PATCH 3/8] vfio: route device_feature through io_ops Hugo Komatsu
2026-09-03 15:35 ` Cédric Le Goater
2026-09-03 13:08 ` [PATCH 4/8] vfio: route device_reset " Hugo Komatsu
2026-09-03 15:44 ` Cédric Le Goater
2026-09-03 13:08 ` [PATCH 5/8] vfio: use io_ops abstraction for migration related ioctls Hugo Komatsu
2026-09-08 14:47 ` John Levon [this message]
2026-09-03 13:08 ` [PATCH 6/8] vfio-user: enable DMA logging for dirty page tracking Hugo Komatsu
2026-09-08 14:52 ` John Levon
2026-09-03 13:08 ` [PATCH 7/8] vfio-user: implement mig_data read/write socket operations Hugo Komatsu
2026-09-08 14:55 ` John Levon
2026-09-03 13:08 ` [PATCH 8/8] vfio-user: enable live migration for pci devices Hugo Komatsu
2026-09-08 14:58 ` John Levon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqAgFCuaJeqkCQ6e@lent \
--to=john.levon@nutanix.com \
--cc=akrowiak@linux.ibm.com \
--cc=alex@shazbot.org \
--cc=clg@redhat.com \
--cc=cohuck@redhat.com \
--cc=farman@linux.ibm.com \
--cc=hugo.komatsu@nutanix.com \
--cc=jjherne@linux.ibm.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mjrosato@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=pierrick.bouvier@oss.qualcomm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rafael@trfs.me \
--cc=thanos.makatos@nutanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.