From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Yicong Yang <yang.yicong@picoheart.com>
Cc: ilpo.jarvinen@linux.intel.com, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
jirislaby@kernel.org, geshijian@picoheart.com,
yangyang.8776@picoheart.com, yanligen@picoheart.com
Subject: Re: [PATCH v3] serial: 8250_dw: Prefer SRBR in bogus RX timeout workaround if available
Date: Tue, 8 Sep 2026 18:58:17 +0300 [thread overview]
Message-ID: <aqAwmQpO_6e2oQZx@ashevche-desk.local> (raw)
In-Reply-To: <20260908141524.20302-1-yang.yicong@picoheart.com>
On Tue, Sep 08, 2026 at 10:15:24PM +0800, Yicong Yang wrote:
> The DW uart could get into the cases where a bogus RX timeout
> interrupt is asserted but no available data. This could be
> workaround by doing a bogus read.
>
> Currently the driver's using the standard RBR (receive buffer
> register) for this bogus read. However the reading of RBR
> in this case is allowed to raise a hardware error if vendor
> choose to implement in this way (our platform). It's also
> allowed to do the bogus read using SRBR (shadow RBR) for
> workaround which won't raise the hardware error. So change
> to use the SRBR to workaround the issue if it's available.
Okay now.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-09-08 15:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 14:15 [PATCH v3] serial: 8250_dw: Prefer SRBR in bogus RX timeout workaround if available Yicong Yang
2026-09-08 14:29 ` sashiko-bot
2026-09-08 15:58 ` Andy Shevchenko [this message]
2026-09-17 10:47 ` Kumar, Udit
2026-09-17 13:06 ` Yicong Yang
2026-09-17 13:33 ` Kumar, Udit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqAwmQpO_6e2oQZx@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=geshijian@picoheart.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=yang.yicong@picoheart.com \
--cc=yangyang.8776@picoheart.com \
--cc=yanligen@picoheart.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.