All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Masney <bmasney@redhat.com>
To: Jia Wang <wangjia@ultrarisc.com>
Cc: Stephen Boyd <sboyd@kernel.org>,
	Brian Masney <bmasney+clk@redhat.com>,
	Jerome Brunet <jbrunet+clk@baylibre.com>,
	linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: ultrarisc: Register DP1000 clock provider earlier
Date: Tue, 8 Sep 2026 13:50:44 -0400	[thread overview]
Message-ID: <aqBK9J1ZTJAGgxCu@redhat.com> (raw)
In-Reply-To: <178876250098.2581040.1337852022443550878.b4-reply@b4>

Hi Jia,

On Mon, Sep 07, 2026 at 02:28:20PM +0800, Jia Wang wrote:
> On 2026-08-24 12:37 -0400, Brian Masney wrote:
> > On Thu, Aug 20, 2026 at 10:50:47AM +0800, Jia Wang wrote:
> > > The DP1000 PCIe and clock drivers both register at the device initcall
> > > level. Since the PCIe driver is linked first, its probe runs before the
> > > clock provider is available and defers.
> > > 
> > > sysfb_init() runs at the same initcall level before deferred probes are
> > > retried. It claims the firmware framebuffer aperture, so the later PCIe
> > > host probe cannot allocate the overlapping prefetchable window and the
> > > GPU is not enumerated.
> > > 
> > > Register the clock provider with subsys_initcall() when built in so PCIe
> > > host probing completes before sysfb_init(). Keep module builds using the
> > > normal module init and exit paths.
> > > 
> > > Fixes: 3948a36be42b ("clk: ultrarisc: Add DP1000 clock driver")
> > > Signed-off-by: Jia Wang <wangjia@ultrarisc.com>
> > 
> > Reviewed-by: Brian Masney <bmasney@redhat.com>
> > 
> > I see this same pattern is also used by lots of qcom gcc drivers, 4
> > Renesas drivers, and a few other drivers.
> > 
> 
> A gentle ping on this fix.
> 
> Please let me know if any changes or a resend are needed.

I just posted this series to reduce some boilerplate code across all of
the clk drivers:

https://lore.kernel.org/linux-clk/20260908-subsys_initcall-v1-0-cbccf4cd4288@redhat.com/T/#t

Let's see what people think about this.

Brian


      reply	other threads:[~2026-09-08 17:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-20  2:50 [PATCH] clk: ultrarisc: Register DP1000 clock provider earlier Jia Wang
2026-08-24 16:37 ` Brian Masney
2026-09-07  6:28   ` Jia Wang
2026-09-08 17:50     ` Brian Masney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aqBK9J1ZTJAGgxCu@redhat.com \
    --to=bmasney@redhat.com \
    --cc=bmasney+clk@redhat.com \
    --cc=jbrunet+clk@baylibre.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sboyd@kernel.org \
    --cc=wangjia@ultrarisc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.