From: Niklas Cassel <cassel@kernel.org>
To: Nikolay Borisov <nik.borisov@suse.com>
Cc: sashiko-reviews@lists.linux.dev, dlemoal@kernel.org,
linux-ide@vger.kernel.org
Subject: Re: [PATCH] ata: sata_dwc_460ex: Don't enable interrupt if libATA core registration fails
Date: Wed, 9 Sep 2026 11:27:27 +0200 [thread overview]
Message-ID: <aqEmf-68Dvw-zj_6@ryzen> (raw)
In-Reply-To: <8e426afc-b534-454f-9880-2b25764f370a@suse.com>
On Tue, Sep 08, 2026 at 05:34:51PM +0300, Nikolay Borisov wrote:
>
>
> On 8.09.26 г. 17:30 ч., sashiko-bot@kernel.org wrote:
> > Thank you for your contribution! Sashiko AI review found 5 potential issue(s) to consider:
> >
> > New issues:
> > - [Low] The patch introduces a `goto err;` statement in `sata_dwc_probe()`, but there is no label named `err:` defined in the function, resulting in a compilation error.
>
> Fair point, however I'd like to hear from an expert whether enabling the
> interrupt without properly registering with libata core is fine or not? I.e
> whether this particular fix makes sense?
Your fix makes sense.
Kind regards,
Niklas
prev parent reply other threads:[~2026-09-09 9:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 14:15 [PATCH] ata: sata_dwc_460ex: Don't enable interrupt if libATA core registration fails Nikolay Borisov
2026-09-08 14:30 ` sashiko-bot
2026-09-08 14:34 ` Nikolay Borisov
2026-09-09 9:27 ` Niklas Cassel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqEmf-68Dvw-zj_6@ryzen \
--to=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=nik.borisov@suse.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.