From: Florian Westphal <fw@strlen.de>
To: netdev-bot+sashiko@kernel.org
Cc: elb12345@hotmail.co.uk, pablo@netfilter.org,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kuba@kernel.org, rc@rexion.ai
Subject: Re: [PATCH] netfilter: conntrack_amanda: fix port value truncation
Date: Wed, 9 Sep 2026 14:14:20 +0200 [thread overview]
Message-ID: <aqFNnGrfB65odAFn@strlen.de> (raw)
In-Reply-To: <178894676277.219967.1844924383954861310@kernel.org>
netdev-bot+sashiko@kernel.org <netdev-bot+sashiko@kernel.org> wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue(s) to consider:
>
> Critical: 0 · High: 1 · Medium: 0 · Low: 0
>
> - [High] net/netfilter/nf_conntrack_amanda.c:amanda_help() — the new
> range check closes only the htons() truncation window for numbers that…
There is queued patch in the backlog that added a unified port parser
for use by all helpers:
https://patchwork.ozlabs.org/project/netfilter-devel/patch/20260503083220.630655-2-rc@rexion.ai/
I think it would be good if the author of that series would rebase and
resend a new version.
next prev parent reply other threads:[~2026-09-09 12:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-06 23:37 [PATCH] netfilter: conntrack_amanda: fix port value truncation Aamir Ahmed
2026-09-07 6:56 ` Chenguang Zhao
2026-09-07 16:37 ` Pablo Neira Ayuso
2026-09-08 1:37 ` Aamir Ahmed
2026-09-07 8:33 ` Florian Westphal
2026-09-09 9:39 ` netdev-bot+sashiko
2026-09-09 12:14 ` Florian Westphal [this message]
2026-09-09 23:28 ` Aamir Ahmed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqFNnGrfB65odAFn@strlen.de \
--to=fw@strlen.de \
--cc=coreteam@netfilter.org \
--cc=elb12345@hotmail.co.uk \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=rc@rexion.ai \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.