From: Vinod Koul <vkoul@kernel.org>
To: Li Youhong <dayou5941@163.com>
Cc: Eugeniy.Paltsev@synopsys.com, Frank.Li@kernel.org,
dmaengine@vger.kernel.org, Li Youhong <liyouhong@kylinos.cn>,
Frank Li <Frank.Li@nxp.com>
Subject: Re: [PATCH v4] dmaengine: dw-axi-dmac: convert to clk bulk APIs
Date: Wed, 9 Sep 2026 17:55:02 +0530 [thread overview]
Message-ID: <aqFQHtOhhPOEmh8E@parshuram> (raw)
In-Reply-To: <20260903015438.2514100-1-dayou5941@163.com>
On 03-09-26, 09:54, Li Youhong wrote:
> From: Li Youhong <liyouhong@kylinos.cn>
>
> axi_dma_resume() enables cfgr_clk then core_clk. If enabling
> core_clk fails, return without disabling cfgr_clk, leaking the
> already-enabled clock.
>
> Switch both clocks to the clk bulk helpers so prepare/enable
> failures roll back automatically, and update probe/remove/
> suspend/resume accordingly.
>
> In dw_remove(), check clk_bulk_prepare_enable(). On failure skip
> MMIO and the matching disable to avoid unbalanced clk disable;
> always continue with IRQ/OF/tasklet teardown.
Hey, this doesnot apply against current code, can you rebase and send
>
> Fixes: 1fe20f1b8454 ("dmaengine: Introduce DW AXI DMAC driver")
why is this a fix?
--
~Vinod
next prev parent reply other threads:[~2026-09-09 12:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 1:54 [PATCH v4] dmaengine: dw-axi-dmac: convert to clk bulk APIs Li Youhong
2026-09-03 2:06 ` sashiko-bot
2026-09-04 15:45 ` Frank Li
2026-09-09 12:25 ` Vinod Koul [this message]
2026-09-10 2:46 ` 李佑鸿
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqFQHtOhhPOEmh8E@parshuram \
--to=vkoul@kernel.org \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=Frank.Li@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=dayou5941@163.com \
--cc=dmaengine@vger.kernel.org \
--cc=liyouhong@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.