From: Harry Yoo <harry@kernel.org>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-block@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@infradead.org>,
Vlastimil Babka <vbabka@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Hao Li <hao.li@linux.dev>, Christoph Lameter <cl@gentwo.org>,
David Rientjes <rientjes@google.com>,
Roman Gushchin <roman.gushchin@linux.dev>
Subject: Re: [PATCH 1/3] mm: make mempool_alloc_from_pool() return bool
Date: Wed, 9 Sep 2026 14:02:32 +0100 [thread overview]
Message-ID: <aqFXHT546O-ay4W6@thinkstation> (raw)
In-Reply-To: <20260806221031.79050-2-ebiggers@kernel.org>
On Thu, Aug 06, 2026 at 03:10:29PM -0700, Eric Biggers wrote:
> mempool_alloc_from_pool() is intentionally all-or-nothing, so make it
> return a bool rather than the number of elements allocated.
>
> Then make mempool_alloc_bulk() return right away if
> mempool_alloc_from_pool() succeeds, rather than jumping back to the
> retry_alloc label to allocate nothing and then returning.
>
> Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> ---
Looks good to me,
Reviewed-by: Harry Yoo (Meta) <harry@kernel.org>
--
Cheers,
Harry / Hyeonggon
next prev parent reply other threads:[~2026-09-09 13:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-06 22:10 [PATCH 0/3] Fix a deadlock in blk-crypto-fallback Eric Biggers
2026-08-06 22:10 ` [PATCH 1/3] mm: make mempool_alloc_from_pool() return bool Eric Biggers
2026-08-10 15:59 ` Christoph Hellwig
2026-09-09 13:02 ` Harry Yoo [this message]
2026-08-06 22:10 ` [PATCH 2/3] mm: support fallible mempool_alloc_bulk() Eric Biggers
2026-08-10 16:00 ` Christoph Hellwig
2026-08-10 16:14 ` Eric Biggers
2026-08-10 17:21 ` Christoph Hellwig
2026-08-10 18:22 ` Eric Biggers
2026-08-11 20:13 ` Christoph Hellwig
2026-08-11 21:03 ` Eric Biggers
2026-08-12 13:36 ` Christoph Hellwig
2026-08-06 22:10 ` [PATCH 3/3] blk-crypto-fallback: Fix deadlock when encrypting large bio in dm layer Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqFXHT546O-ay4W6@thinkstation \
--to=harry@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=cl@gentwo.org \
--cc=ebiggers@kernel.org \
--cc=hao.li@linux.dev \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.