All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shengchao.guo@oss.qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bartosz Golaszewski <brgl@kernel.org>,
	Dhruvin Rajpura <dhruvin.rajpura@oss.qualcomm.com>,
	Anandu Krishnan E <anandu.e@oss.qualcomm.com>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/6] arm64: dts: qcom: nord: Add remoteproc and PMIC support
Date: Wed, 9 Sep 2026 21:16:38 +0800	[thread overview]
Message-ID: <aqFcNhB9ZeQlkOFh@QCOM-aGQu4IUr3Y> (raw)
In-Reply-To: <bc051d4d-c94b-4f01-bc77-a4da93331d6c@oss.qualcomm.com>

On Wed, Sep 09, 2026 at 02:13:35PM +0200, Konrad Dybcio wrote:
> On 9/7/26 2:06 PM, Shawn Guo wrote:
> > On Fri, Sep 04, 2026 at 12:00:40PM +0200, Konrad Dybcio wrote:
> >> On 9/4/26 10:16 AM, Shawn Guo wrote:
> >>> This series adds ADSP and CDSP remoteproc support, the SPMI PMIC arbiter
> >>> and the PMIC descriptions for the Qualcomm Nord platform, and adds the
> >>> initial device tree for the Nord Ride Embedded board.
> >>>
> >>> Tested on next-20260903
> >>>
> >>> Dependencies:
> >>> - NMXC define: commit e484a765f543 ("dt-bindings: power: qcom,rpmhpd: Add NMXC power domain index")
> >>>   from git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/linux-pm.git dt
> >>> - Base DTS: https://lore.kernel.org/all/20260903140617.441111-1-shengchao.guo@oss.qualcomm.com/
> >>> - PMAU0102 MFD: https://lore.kernel.org/all/20260830034719.140213-1-shengchao.guo@oss.qualcomm.com/
> >>> - PMAU0102 thermal: https://lore.kernel.org/all/20260830101025.191697-1-shengchao.guo@oss.qualcomm.com/
> >>> - PMM8654AU RTC: https://lore.kernel.org/all/20260904074541.590485-1-shengchao.guo@oss.qualcomm.com/
> >>>
> >>> Changes for v2:
> >>> - Align PMIC comments in nord-ride-embedded.dts with nord-rrd.dts
> >>> - Drop unneeded regulator-always-on and regulator-boot-on from RPMh
> >>>   regulators
> >>
> >> It still remains on something like 40% of the defined regulators
> >> without any nearby comment justifying that - are all of these
> >> intentional and necessary?
> > 
> > Yes, all of those are intentional.
> > 
> > - Supplies of LPDDR5
> > 
> >   vreg_s1a_vdd2h_l  -->  VDD2H_LPDDR5_01
> >   vreg_s5g_vdd2h_h  -->  VDD2H_LPDDR5_23
> >   vreg_l1k_vdd2l    -->  VDD2L_LPDDR5_01
> >   vreg_l1f_vdd2l    -->  VDD2L_LPDDR5_23
> >   vreg_l3k_vdd1     -->  VDD1_LPDDR5_01
> >   vreg_l3f_vdd1     -->  VDD1_LPDDR5_23
> > 
> > - Supplies of PMICs
> > 
> >   vreg_l8a_1p8     -->  VDD_LDO_XO
> >   vreg_s3a_1p8     -->  VDD_PX3 
> >   vreg_s5a_mv      -->  VREG_LDO_MV
> >   vreg_s7f_lv_sub  -->  VREG_LDO_LV
> > 
> > - Supplies of Nord SoC
> > 
> >   vreg_l7a_1p2     -->  VDD_PX14
> 
> Does RPMH require HLOS to cast these votes? Generally such supplies
> should be taken care of in the fw

Good point! I just did a couple of tests by:

- dropping regulator-always-on/regulator-boot-on from these regulators
- dropping these regulators completely from DTS

Both booted fine (the nhlos software for Nord Embedded variant are still
under heavy development though).

So what do you prefer, dropping always-on/boot-on property or
the regulators completely?

Shawn

  reply	other threads:[~2026-09-09 13:16 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-04  8:16 [PATCH v2 0/6] arm64: dts: qcom: nord: Add remoteproc and PMIC support Shawn Guo
2026-09-04  8:16 ` [PATCH v2 1/6] arm64: dts: qcom: nord: Add support for ADSP and CDSPs Shawn Guo
2026-09-20  4:50   ` Shawn Guo
2026-09-04  8:16 ` [PATCH v2 2/6] arm64: dts: qcom: nord-rrd: Enable " Shawn Guo
2026-09-04  9:58   ` Konrad Dybcio
2026-09-04  8:16 ` [PATCH v2 3/6] arm64: dts: qcom: nord: Add the SPMI PMIC arbiter Shawn Guo
2026-09-04  8:16 ` [PATCH v2 4/6] arm64: dts: qcom: nord: Add PMAU0102 and PMM8650AU PMIC support Shawn Guo
2026-09-09 12:23   ` Konrad Dybcio
2026-09-04  8:16 ` [PATCH v2 5/6] dt-bindings: arm: qcom: Document Nord Ride Embedded board Shawn Guo
2026-09-07 11:33   ` Shawn Guo
2026-09-04  8:16 ` [PATCH v2 6/6] arm64: dts: qcom: Add initial support for " Shawn Guo
2026-09-09 12:17   ` Konrad Dybcio
2026-09-04 10:00 ` [PATCH v2 0/6] arm64: dts: qcom: nord: Add remoteproc and PMIC support Konrad Dybcio
2026-09-07 12:06   ` Shawn Guo
2026-09-09 12:13     ` Konrad Dybcio
2026-09-09 13:16       ` Shawn Guo [this message]
2026-09-09 13:50         ` Konrad Dybcio
2026-09-11 20:33           ` Kamal Wadhwa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aqFcNhB9ZeQlkOFh@QCOM-aGQu4IUr3Y \
    --to=shengchao.guo@oss.qualcomm.com \
    --cc=anandu.e@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=brgl@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dhruvin.rajpura@oss.qualcomm.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.