From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Johan Hovold <johan@kernel.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Ulf Hansson <ulfh@kernel.org>,
Jakov Novak <jakovnovak30@gmail.com>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linux.dev,
Guangshuo Li <lgs201920130244@gmail.com>,
Runyu Xiao <runyu.xiao@seu.edu.cn>,
Shuah Khan <skhan@linuxfoundation.org>,
syzbot+1ee4f3b9228e35f14677@syzkaller.appspotmail.com
Subject: Re: [PATCH] mmc: vub300: fix sleeping function call from invalid context in vub300_inactivity_timer_expired
Date: Wed, 9 Sep 2026 19:24:46 +0200 [thread overview]
Message-ID: <aqGWWhvL5CKH2mgx@shikoro> (raw)
In-Reply-To: <aqEDb0THnCM-Q_Vy@hovoldconsulting.com>
[-- Attachment #1: Type: text/plain, Size: 807 bytes --]
> > > Sure, but should you be scheduling rescan work before all resources have
> > > been set up and the host has been registered?
> >
> > I would like to defer that question to the TMIO experts.
From a high level view, independently of TMIO/SDHI...
> Are they on CC?
>
> Ulf, perhaps you can take a look at this? It seems wrong to enable
> interrupts and trigger rescans before the host controller has been set
> up and registered.
... it is always a good practice to enable irqs only when the device is
fully set up. From a glimpse, this seems to be the case here as well.
It needs serious testing, though. SDHI is a complex, organically grown
mass of code. There might be subtle side effects. It should still be
worth it IMO. I can put it on my todo list, but no promises...
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2026-09-09 17:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-16 15:38 [PATCH] mmc: vub300: fix sleeping function call from invalid context in vub300_inactivity_timer_expired Jakov Novak
2026-08-17 8:13 ` Johan Hovold
2026-08-30 9:32 ` Tetsuo Handa
2026-09-07 11:16 ` Jakov Novak
2026-09-07 12:19 ` Geert Uytterhoeven
2026-09-07 12:17 ` Geert Uytterhoeven
2026-09-07 13:55 ` Johan Hovold
2026-09-07 14:48 ` Geert Uytterhoeven
2026-09-09 6:57 ` Johan Hovold
2026-09-09 7:38 ` Geert Uytterhoeven
2026-09-09 8:02 ` Johan Hovold
2026-09-09 17:24 ` Wolfram Sang [this message]
2026-09-11 7:04 ` Johan Hovold
2026-09-11 11:14 ` Jakov Novak
2026-09-14 12:28 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqGWWhvL5CKH2mgx@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=geert@linux-m68k.org \
--cc=jakovnovak30@gmail.com \
--cc=johan@kernel.org \
--cc=lgs201920130244@gmail.com \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=runyu.xiao@seu.edu.cn \
--cc=skhan@linuxfoundation.org \
--cc=syzbot+1ee4f3b9228e35f14677@syzkaller.appspotmail.com \
--cc=ulfh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.