From: Nicolin Chen <nicolinc@nvidia.com>
To: Jason Gunthorpe <jgg@nvidia.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, <joro@8bytes.org>,
Robin Murphy <robin.murphy@arm.com>, <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
<aneesh.kumar@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Gavin Shan <gshan@redhat.com>, Vikram Sethi <vsethi@nvidia.com>,
"Anshuman Khandual" <anshuman.khandual@arm.com>,
Shanker Donthineni <sdonthineni@nvidia.com>,
Mostafa Saleh <smostafa@google.com>, <rppt@kernel.org>,
Thomas Huth <thuth@redhat.com>, Marc Zyngier <maz@kernel.org>,
Ryan Roberts <ryan.roberts@arm.com>, <kas@kernel.org>,
Kohei Enju <enju.kohei@fujitsu.com>,
Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
Ard Biesheuvel <ardb@kernel.org>,
James Morse <james.morse@arm.com>,
Steven Price <steven.price@arm.com>,
Sang-Heon Jeon <ekffu200098@gmail.com>,
Omar Sandoval <osandov@fb.com>,
Andrew Morton <akpm@linux-foundation.org>,
Jinjie Ruan <ruanjinjie@huawei.com>,
Sam Edwards <cfsworks@gmail.com>,
Douglas Anderson <dianders@chromium.org>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
Chen-Yu Tsai <wenst@chromium.org>,
Huacai Chen <chenhuacai@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Pranjal Shrivastava <praan@google.com>,
Ashish Mhetre <amhetre@nvidia.com>,
Shameer Kolothum <skolothumtho@nvidia.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <iommu@lists.linux.dev>,
<driver-core@lists.linux.dev>, Sonang Patel <sonangp@nvidia.com>,
Ankit Agrawal <ankita@nvidia.com>
Subject: Re: [PATCH v1 8/8] iommu/arm-smmu-v3: Probe a guest-level Realm VSMMU via RSI commands
Date: Wed, 9 Sep 2026 21:23:34 -0700 [thread overview]
Message-ID: <aqIwxldvOHWlNGRu@nvidia.com> (raw)
In-Reply-To: <df25452641dc126eb334a1bfbe5eee16cc8a8953.1789010941.git.nicolinc@nvidia.com>
On Wed, Sep 09, 2026 at 08:32:51PM -0700, Nicolin Chen wrote:
> @@ -5542,6 +5591,12 @@ static int arm_smmu_device_probe(struct platform_device *pdev)
> }
> ioaddr = res->start;
>
> + if (is_realm_world()) {
> + ret = arm_smmu_probe_realm_vsmmu(smmu, res);
> + if (ret)
> + return ret;
Sashiko pointed out a new finding (didn't appear in my local runs)
that arm_smmu_impl_probe() would allow an untrusted hypervisor to
provide a malicious ACPI/DT table specifying a vendor extension.
I think it's valid, So, we likely need a guard, until impl has RMM
level support with additional RSI validation:
- smmu = arm_smmu_impl_probe(smmu);
- if (IS_ERR(smmu))
- return PTR_ERR(smmu);
+ if (!is_realm_world()) {
+ smmu = arm_smmu_impl_probe(smmu);
+ if (IS_ERR(smmu))
+ return PTR_ERR(smmu);
+ }
Nicolin
prev parent reply other threads:[~2026-09-10 4:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-10 3:32 [PATCH v1 0/8] iommu/arm-smmu-v3: Support guest-level Realm VSMMU (Part-1) Nicolin Chen
2026-09-10 3:32 ` [PATCH v1 1/8] firmware: arm_rmm: Move RSI support out of arch/arm64 Nicolin Chen
2026-09-10 3:32 ` [PATCH v1 2/8] firmware: arm_rmm: Add VSMMU commands and fields Nicolin Chen
2026-09-10 3:32 ` [PATCH v1 3/8] dma-mapping: Let a device declare that it reaches private memory Nicolin Chen
2026-09-10 3:32 ` [PATCH v1 4/8] dma-mapping: Keep DMA memory private for capable devices Nicolin Chen
2026-09-10 3:32 ` [PATCH v1 5/8] iommu: Let a driver mark an IOMMU as confidential Nicolin Chen
2026-09-10 3:32 ` [PATCH v1 6/8] iommu: Introduce TDISP T=0 state for confidential IOMMUs Nicolin Chen
2026-09-10 3:32 ` [PATCH v1 7/8] iommu: Park TDISP T=0 devices in the blocking domain Nicolin Chen
2026-09-10 3:32 ` [PATCH v1 8/8] iommu/arm-smmu-v3: Probe a guest-level Realm VSMMU via RSI commands Nicolin Chen
2026-09-10 4:23 ` Nicolin Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqIwxldvOHWlNGRu@nvidia.com \
--to=nicolinc@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=amhetre@nvidia.com \
--cc=aneesh.kumar@kernel.org \
--cc=ankita@nvidia.com \
--cc=anshuman.khandual@arm.com \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=cfsworks@gmail.com \
--cc=chenhuacai@kernel.org \
--cc=dakr@kernel.org \
--cc=dianders@chromium.org \
--cc=driver-core@lists.linux.dev \
--cc=ekffu200098@gmail.com \
--cc=enju.kohei@fujitsu.com \
--cc=florian.fainelli@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=gshan@redhat.com \
--cc=iommu@lists.linux.dev \
--cc=james.morse@arm.com \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=kas@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=osandov@fb.com \
--cc=praan@google.com \
--cc=rafael@kernel.org \
--cc=robin.murphy@arm.com \
--cc=rppt@kernel.org \
--cc=ruanjinjie@huawei.com \
--cc=ryan.roberts@arm.com \
--cc=sdonthineni@nvidia.com \
--cc=skolothumtho@nvidia.com \
--cc=smostafa@google.com \
--cc=sonangp@nvidia.com \
--cc=steven.price@arm.com \
--cc=suzuki.poulose@arm.com \
--cc=tan.shaopeng@jp.fujitsu.com \
--cc=thuth@redhat.com \
--cc=tzimmermann@suse.de \
--cc=vsethi@nvidia.com \
--cc=wenst@chromium.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.