From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <xen-devel-bounces@lists.xenproject.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.lore.kernel.org (Postfix) with ESMTPS id 46C44C79FB9
	for <xen-devel@archiver.kernel.org>; Thu, 10 Sep 2026 07:44:25 +0000 (UTC)
Received: from list by lists.xenproject.org with outflank-mailman.1414060.1643899 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1x4ZS8-0000bD-88; Thu, 10 Sep 2026 07:44:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 1414060.1643899; Thu, 10 Sep 2026 07:44:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1x4ZS8-0000b6-5H; Thu, 10 Sep 2026 07:44:12 +0000
Received: by outflank-mailman (input) for mailman id 1414060;
 Thu, 10 Sep 2026 07:44:11 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <roger@xenproject.org>) id 1x4ZS6-0000b0-VJ
 for xen-devel@lists.xenproject.org; Thu, 10 Sep 2026 07:44:10 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.96)
 (envelope-from <roger@xenproject.org>) id 1x4ZS5-007zuY-1R;
 Thu, 10 Sep 2026 07:44:09 +0000
Received: from 224.pool85-54-217.dynamic.orange.es ([85.54.217.224]
 helo=localhost) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96)
 (envelope-from <roger@xenproject.org>) id 1x4ZS5-0069N6-2z;
 Thu, 10 Sep 2026 07:44:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=In-Reply-To:Content-Transfer-Encoding:
	Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date;
	bh=kuAXpiu8NosbbBAcbeswokbW1v5xo6hOB9np/FBn9no=; b=EEmyBLb443GbsSJ7scFDsaCBNO
	rMzWTlO5bKcZwSt+rt4uf3zOzISdjYllUdcRsFYPUzoAVECMJT6j0jQ4dl4U37i6abAj8MEUFkNXy
	SmpQrS8JwMyps5vB9pXl4Z3eMEY/Z6zw035N0yaxje9H/p17iAgEV68kUv6gqLYIGqb4=;
Date: Thu, 10 Sep 2026 09:44:07 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger@xenproject.org>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Nicola Vetrini <nicola.vetrini@bugseng.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Teddy Astie <teddy.astie@vates.tech>
Subject: Re: [PATCH 12/12] x86/nSVM: address Misra 2.1 rule violation
Message-ID: <aqJfx8-8t1I-wtAn@macbook.local>
References: <90d0e3d6-2e12-43f1-815d-7936ca4c5fc6@suse.com>
 <b5601922-1f8b-46ff-ac3d-0e4310773f85@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <b5601922-1f8b-46ff-ac3d-0e4310773f85@suse.com>

On Fri, Aug 28, 2026 at 09:06:20AM +0200, Jan Beulich wrote:
> The 16-bit range of "port" is fully handled by the switch(). Therefore the
> default: case is reported unreachable by Eclair. Insert BUILD_ERROR() to
> annotate this for Eclair.
> 
> No functional change.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Roger Pau Monné <roger@xenproject.org>

That however is a bit weird IMO, as we have usually said we would
prefer not to use fixed width types in general, and hence one might
argue that port should be unsigned int. Then the BUILD_ERROR() might
trigger?

Thanks, Roger.