From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: "Mi, Dapeng" <dapeng1.mi@linux.intel.com>
Cc: Thomas Falcon <thomas.falcon@intel.com>,
Namhyung Kim <namhyung@kernel.org>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
James Clark <james.clark@linaro.org>
Subject: Re: [PATCH v7 5/6] perf tools: Show memory region in perf-script subcommand
Date: Thu, 10 Sep 2026 11:10:09 -0300 [thread overview]
Message-ID: <aqK6QbKfSBE4JZPc@x2> (raw)
In-Reply-To: <c867ffcd-d2de-49a5-977c-5579b1029ca9@linux.intel.com>
On Thu, Sep 10, 2026 at 10:22:53AM +0800, Mi, Dapeng wrote:
>
> On 9/10/2026 12:02 AM, Thomas Falcon wrote:
> > From: Dapeng Mi <dapeng1.mi@linux.intel.com>
> >
> > Show the memory region in perf-script subcommand. Memory region is found
> > in the mem_region field of the memory information data source. This
> > field was included with the introduction of support for the Off-module
> > Response facility (OMR) [1] in Intel's Diamond Rapids and Nova Lake
> > Architectures.
> >
> > An example of perf-script output with the new memory region field is shown
> > below:
> >
> > random 10e6a100042 |OP LOAD|LVL L0 hit|SNP None|TLB L1 or L2 hit|LCK Yes|BLK N/A|Region N/A 7f32ae64a2ec
> > random 2411a68201042 |OP LOAD|LVL RAM hit|SNP Hit|TLB L1 or L2 hit|LCK No|BLK N/A|Region Mem-1 561de7f8910a
> > random 10e6a100042 |OP LOAD|LVL L0 hit|SNP None|TLB L1 or L2 hit|LCK Yes|BLK N/A|Region N/A 7f32ae64a2d0
> > random 20e6a100042 |OP LOAD|LVL L0 hit|SNP None|TLB L1 or L2 hit|LCK Yes|BLK Data|Region N/A 7f32ae64a2d0
> > random 20e6a100042 |OP LOAD|LVL L0 hit|SNP None|TLB L1 or L2 hit|LCK Yes|BLK Data|Region N/A 7f32ae64a2d0
> > random 10e6a100042 |OP LOAD|LVL L0 hit|SNP None|TLB L1 or L2 hit|LCK Yes|BLK N/A|Region N/A 7f32ae64a2ec
> > random 10e6a100042 |OP LOAD|LVL L0 hit|SNP None|TLB L1 or L2 hit|LCK Yes|BLK N/A|Region N/A 7f32ae64a2d0
> > random 10e6a100042 |OP LOAD|LVL L0 hit|SNP None|TLB L1 or L2 hit|LCK Yes|BLK N/A|Region N/A 7f32ae64a2d0
> > random 2411a68201042 |OP LOAD|LVL RAM hit|SNP Hit|TLB L1 or L2 hit|LCK No|BLK N/A|Region Mem-1 561de7f8910a
> > random 10e6a100042 |OP LOAD|LVL L0 hit|SNP None|TLB L1 or L2 hit|LCK Yes|BLK N/A|Region N/A 7f32ae64a2ec
> > random 10e6a100042 |OP LOAD|LVL L0 hit|SNP None|TLB L1 or L2 hit|LCK Yes|BLK N/A|Region N/A 7f32ae64a2d0
> >
> > [1]: https://lore.kernel.org/all/20260114011750.350569-1-dapeng1.mi@linux.intel.com/
> >
> > Assisted-by: Sashiko:gemini-3.1-pro-preview
> > Assisted-by: GitHub-Copilot:claude-opus-4-8
> > Reviewed-by: Ian Rogers <irogers@google.com>
> > Signed-off-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
>
> Add your "Co-developed-by" tag here. Thanks.
I'll wait for v8 then, ok?
- Arnaldo
>
> > Signed-off-by: Thomas Falcon <thomas.falcon@intel.com>
> > ---
> > v4: Drop the global show-region flag; pass perf_session to
> > perf_script__meminfo_scnprintf() and gate the Region field
> > on the feature bit, with a pipe-mode fallback
> >
> > v3: make memory region reporting conditional on feature bit
> > ---
> > tools/perf/builtin-script.c | 13 +--
> > tools/perf/util/mem-events.c | 86 ++++++++++++++++++-
> > tools/perf/util/mem-events.h | 4 +-
> > .../scripting-engines/trace-event-python.c | 5 +-
> > 4 files changed, 98 insertions(+), 10 deletions(-)
> >
> > diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
> > index ad8ca08ceb5f..c7454155038d 100644
> > --- a/tools/perf/builtin-script.c
> > +++ b/tools/perf/builtin-script.c
> > @@ -2078,11 +2078,12 @@ static int evlist__max_name_len(struct evlist *evlist)
> > return max;
> > }
> >
> > -static int data_src__fprintf(u64 data_src, FILE *fp)
> > +static int data_src__fprintf(struct perf_session *session,
> > + u64 data_src, FILE *fp)
> > {
> > struct mem_info *mi = mem_info__new();
> > - char decode[100];
> > - char out[100];
> > + char decode[200];
> > + char out[200];
> > static int maxlen;
> > int len;
> >
> > @@ -2090,10 +2091,10 @@ static int data_src__fprintf(u64 data_src, FILE *fp)
> > return -ENOMEM;
> >
> > mem_info__data_src(mi)->val = data_src;
> > - perf_script__meminfo_scnprintf(decode, 100, mi);
> > + perf_script__meminfo_scnprintf(decode, 200, mi, session);
> > mem_info__put(mi);
> >
> > - len = scnprintf(out, 100, "%16" PRIx64 " %s", data_src, decode);
> > + len = scnprintf(out, 200, "%16" PRIx64 " %s", data_src, decode);
> > if (maxlen < len)
> > maxlen = len;
> >
> > @@ -2487,7 +2488,7 @@ static void process_event(struct perf_script *script,
> > perf_sample__fprintf_addr(sample, thread, evsel, fp);
> >
> > if (PRINT_FIELD(DATA_SRC))
> > - data_src__fprintf(sample->data_src, fp);
> > + data_src__fprintf(evsel__session(evsel), sample->data_src, fp);
> >
> > if (PRINT_FIELD(WEIGHT))
> > fprintf(fp, "%16" PRIu64, sample->weight);
> > diff --git a/tools/perf/util/mem-events.c b/tools/perf/util/mem-events.c
> > index 4fd48fd20055..8ce4996cad8d 100644
> > --- a/tools/perf/util/mem-events.c
> > +++ b/tools/perf/util/mem-events.c
> > @@ -604,8 +604,77 @@ int perf_mem__blk_scnprintf(char *out, size_t sz, const struct mem_info *mem_inf
> > return l;
> > }
> >
> > -int perf_script__meminfo_scnprintf(char *out, size_t sz, const struct mem_info *mem_info)
> > +static int perf_mem__region_scnprintf(char *out, size_t sz, const struct mem_info *mem_info)
> > {
> > + size_t l = 0;
> > + u64 mem = PERF_MEM_REGION_NA;
> > +
> > + sz -= 1; /* -1 for null termination */
> > + out[0] = '\0';
> > +
> > + if (mem_info)
> > + mem = mem_info__const_data_src(mem_info)->mem_region;
> > +
> > + switch (mem) {
> > + case PERF_MEM_REGION_NA:
> > + case PERF_MEM_REGION_RSVD:
> > + l += scnprintf(out + l, sz - l, "N/A");
> > + break;
> > + case PERF_MEM_REGION_L_SHARE:
> > + l += scnprintf(out + l, sz - l, "Local-shared-cache");
> > + break;
> > + case PERF_MEM_REGION_L_NON_SHARE:
> > + l += scnprintf(out + l, sz - l, "Local-non-shared-cache");
> > + break;
> > + case PERF_MEM_REGION_O_IO:
> > + l += scnprintf(out + l, sz - l, "Other-IO");
> > + break;
> > + case PERF_MEM_REGION_O_SHARE:
> > + l += scnprintf(out + l, sz - l, "Other-shared-cache");
> > + break;
> > + case PERF_MEM_REGION_O_NON_SHARE:
> > + l += scnprintf(out + l, sz - l, "Other-non-shared-cache");
> > + break;
> > + case PERF_MEM_REGION_MMIO:
> > + l += scnprintf(out + l, sz - l, "MMIO");
> > + break;
> > + case PERF_MEM_REGION_MEM0:
> > + l += scnprintf(out + l, sz - l, "Mem-0");
> > + break;
> > + case PERF_MEM_REGION_MEM1:
> > + l += scnprintf(out + l, sz - l, "Mem-1");
> > + break;
> > + case PERF_MEM_REGION_MEM2:
> > + l += scnprintf(out + l, sz - l, "Mem-2");
> > + break;
> > + case PERF_MEM_REGION_MEM3:
> > + l += scnprintf(out + l, sz - l, "Mem-3");
> > + break;
> > + case PERF_MEM_REGION_MEM4:
> > + l += scnprintf(out + l, sz - l, "Mem-4");
> > + break;
> > + case PERF_MEM_REGION_MEM5:
> > + l += scnprintf(out + l, sz - l, "Mem-5");
> > + break;
> > + case PERF_MEM_REGION_MEM6:
> > + l += scnprintf(out + l, sz - l, "Mem-6");
> > + break;
> > + case PERF_MEM_REGION_MEM7:
> > + l += scnprintf(out + l, sz - l, "Mem-7");
> > + break;
> > + default:
> > + l += scnprintf(out + l, sz - l, "N/A");
> > + break;
> > + }
> > +
> > + return l;
> > +}
> > +
> > +int perf_script__meminfo_scnprintf(char *out, size_t sz,
> > + const struct mem_info *mem_info,
> > + struct perf_session *session)
> > +{
> > + struct perf_env *env;
> > int i = 0;
> >
> > i += scnprintf(out, sz, "|OP ");
> > @@ -620,6 +689,21 @@ int perf_script__meminfo_scnprintf(char *out, size_t sz, const struct mem_info *
> > i += perf_mem__lck_scnprintf(out + i, sz - i, mem_info);
> > i += scnprintf(out + i, sz - i, "|BLK ");
> > i += perf_mem__blk_scnprintf(out + i, sz - i, mem_info);
> > + if (session) {
> > + /*
> > + * In case the feature bits are not available, as in
> > + * pipe mode, fallback to checking for the existence of
> > + * memory ranges
> > + */
> > + env = perf_session__env(session);
> > + if ((env && session->data->is_pipe && env->nr_memory_ranges) ||
> > + perf_header__has_feat(&session->header,
> > + HEADER_MEMORY_RANGES)) {
> > + i += scnprintf(out + i, sz - i, "|Region ");
> > + i += perf_mem__region_scnprintf(out + i, sz - i,
> > + mem_info);
> > + }
> > + }
> >
> > return i;
> > }
> > diff --git a/tools/perf/util/mem-events.h b/tools/perf/util/mem-events.h
> > index daa22748f9fe..4ebb8109fc3c 100644
> > --- a/tools/perf/util/mem-events.h
> > +++ b/tools/perf/util/mem-events.h
> > @@ -4,6 +4,7 @@
> >
> > #include <stdbool.h>
> > #include <linux/types.h>
> > +#include "session.h"
> >
> > struct perf_mem_event {
> > bool supported;
> > @@ -47,7 +48,8 @@ int perf_mem__snp_scnprintf(char *out, size_t sz, const struct mem_info *mem_inf
> > int perf_mem__lck_scnprintf(char *out, size_t sz, const struct mem_info *mem_info);
> > int perf_mem__blk_scnprintf(char *out, size_t sz, const struct mem_info *mem_info);
> >
> > -int perf_script__meminfo_scnprintf(char *bf, size_t size, const struct mem_info *mem_info);
> > +int perf_script__meminfo_scnprintf(char *bf, size_t size, const struct mem_info *mem_info,
> > + struct perf_session *session);
> >
> > struct c2c_stats {
> > u32 nr_entries;
> > diff --git a/tools/perf/util/scripting-engines/trace-event-python.c b/tools/perf/util/scripting-engines/trace-event-python.c
> > index 8f832ae316ca..e359fe529586 100644
> > --- a/tools/perf/util/scripting-engines/trace-event-python.c
> > +++ b/tools/perf/util/scripting-engines/trace-event-python.c
> > @@ -694,8 +694,9 @@ static void set_sample_read_in_dict(PyObject *dict_sample, struct perf_sample *s
> > static void set_sample_datasrc_in_dict(PyObject *dict,
> > struct perf_sample *sample)
> > {
> > + struct perf_session *session = evsel__session(sample->evsel);
> > struct mem_info *mi = mem_info__new();
> > - char decode[100];
> > + char decode[200];
> >
> > if (!mi)
> > Py_FatalError("couldn't create mem-info");
> > @@ -704,7 +705,7 @@ static void set_sample_datasrc_in_dict(PyObject *dict,
> > PyLong_FromUnsignedLongLong(sample->data_src));
> >
> > mem_info__data_src(mi)->val = sample->data_src;
> > - perf_script__meminfo_scnprintf(decode, 100, mi);
> > + perf_script__meminfo_scnprintf(decode, 200, mi, session);
> > mem_info__put(mi);
> >
> > pydict_set_item_string_decref(dict, "datasrc_decode",
next prev parent reply other threads:[~2026-09-10 14:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 16:02 [PATCH v7 0/6] perf: Add support for memory region/range reporting Thomas Falcon
2026-09-09 16:02 ` [PATCH v7 1/6] perf mem: Fix size tracking for mem_lvl's in perf_script__meminfo_scnprintf() Thomas Falcon
2026-09-09 16:12 ` sashiko-bot
2026-09-09 16:02 ` [PATCH v7 2/6] perf mem: Add support for printing PERF_MEM_LVLNUM_L0 Thomas Falcon
2026-09-09 16:10 ` sashiko-bot
2026-09-09 16:02 ` [PATCH v7 3/6] perf header: Support memory ranges Thomas Falcon
2026-09-09 16:15 ` sashiko-bot
2026-09-09 16:02 ` [PATCH v7 4/6] perf tools: Show memory region in perf-c2c subcommand Thomas Falcon
2026-09-09 16:13 ` sashiko-bot
2026-09-10 2:19 ` Mi, Dapeng
2026-09-09 16:02 ` [PATCH v7 5/6] perf tools: Show memory region in perf-script subcommand Thomas Falcon
2026-09-09 16:17 ` sashiko-bot
2026-09-10 2:22 ` Mi, Dapeng
2026-09-10 14:10 ` Arnaldo Carvalho de Melo [this message]
2026-09-09 16:02 ` [PATCH v7 6/6] perf c2c: print memory region data with stdio output Thomas Falcon
2026-09-09 16:12 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqK6QbKfSBE4JZPc@x2 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=dapeng1.mi@linux.intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=thomas.falcon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.