From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5BA3FC79F9F for ; Thu, 10 Sep 2026 10:21:51 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id B758D3C198F for ; Thu, 10 Sep 2026 12:21:49 +0200 (CEST) Received: from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [IPv6:2001:4b78:1:20::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 2FA393C198F for ; Thu, 10 Sep 2026 12:21:33 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-3.smtp.seeweb.it (Postfix) with ESMTPS id 8682F1A008A0 for ; Thu, 10 Sep 2026 12:21:32 +0200 (CEST) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 20F6021BE9; Thu, 10 Sep 2026 10:21:26 +0000 (UTC) Authentication-Results: smtp-out1.suse.de; none Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E5D2213180; Thu, 10 Sep 2026 10:21:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 5L8QOKWEomqHSAAAD6G6ig (envelope-from ); Thu, 10 Sep 2026 10:21:25 +0000 Date: Thu, 10 Sep 2026 12:21:31 +0200 From: Cyril Hrubis To: Andrea Cervesato Message-ID: References: <20260909-coredump-v10-0-0a25762cac77@suse.com> <20260909-coredump-v10-3-0a25762cac77@suse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260909-coredump-v10-3-0a25762cac77@suse.com> X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: 20F6021BE9 X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 50.00]; REPLY(-4.00)[] X-Rspamd-Action: no action X-Virus-Scanned: clamav-milter 1.0.9 at in-3.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v10 3/3] coredump02: Verify ELF structure and notes X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux Test Project Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > +static void handle_note(uint32_t type, const void *desc, size_t descsz, pid_t pid) > +{ > + if (type == NT_PRPSINFO && descsz >= sizeof(struct elf_prpsinfo)) { > + struct elf_prpsinfo info; > + > + memcpy(&info, desc, sizeof(info)); > + TST_EXP_EQ_STR(info.pr_fname, "coredump02"); I still do not see a reason why this can't be: struct elf_prpsinfo *info = desc; TST_EXP_EQ_STR(info->pr_name, "coredump02"); > + prpsinfo_seen = 1; > + } else if (type == NT_PRSTATUS && descsz >= sizeof(struct elf_prstatus)) { > + struct elf_prstatus st; > + > + memcpy(&st, desc, sizeof(st)); > + > + TST_EXP_EQ_LI(st.pr_pid, pid); > + TST_EXP_EQ_LI(st.pr_cursig, SIGABRT); And here as well. Otherwise: Reviewed-by: Cyril Hrubis -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp