From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6DFECC79FB9 for ; Thu, 10 Sep 2026 12:01:55 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x4dTS-0002cg-V0; Thu, 10 Sep 2026 08:01:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x4dTR-0002aq-5V for qemu-trivial@nongnu.org; Thu, 10 Sep 2026 08:01:49 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x4dTP-0003lj-B4 for qemu-trivial@nongnu.org; Thu, 10 Sep 2026 08:01:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1789041702; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sGW7TlvD5t6s8Hr0C547us3y/cGFqx5U9KDZc+p1CmU=; b=Z8iV/dALX9a/fqdKhPRSbZWqYZZp664BLk2vGH2lHGUgDwCStQA9uPdsWYfZu52EHnTWls cHnRH1baKv1TKAIkCA03jk18hPMzvS2xg+6YJZRf7HMMp2Yy/r/+KYYUuniGGjOOQrkgsF 4WXWcYSxcR+eO4wkajT+ZTG68Cd53eU= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-684-m31_d7F0P96AAP0U-VEYzQ-1; Thu, 10 Sep 2026 08:01:39 -0400 X-MC-Unique: m31_d7F0P96AAP0U-VEYzQ-1 X-Mimecast-MFC-AGG-ID: m31_d7F0P96AAP0U-VEYzQ_1789041698 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3CAEE180086F; Thu, 10 Sep 2026 12:01:38 +0000 (UTC) Received: from redhat.com (headnet03.pony-001.prod.iad2.dc.redhat.com [10.2.32.114]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C1B4030001A2; Thu, 10 Sep 2026 12:01:36 +0000 (UTC) Date: Thu, 10 Sep 2026 13:01:33 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Thomas Huth Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org, Reinoud Zandijk Subject: Re: [PATCH] util/cutils: Use qemu_isdigit() instead of isdigit() Message-ID: References: <20260910112100.365573-1-thuth@redhat.com> MIME-Version: 1.0 In-Reply-To: <20260910112100.365573-1-thuth@redhat.com> User-Agent: Mutt/2.4.0 (2026-06-19) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-MFC-PROC-ID: GbKPVMiwsWeyeimRFH9Xd_gIr1jJBfbC_6qShu6vKz8_1789041698 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-trivial-bounces+qemu-trivial=archiver.kernel.org@nongnu.org Sender: qemu-trivial-bounces+qemu-trivial=archiver.kernel.org@nongnu.org On Thu, Sep 10, 2026 at 01:21:00PM +0200, Thomas Huth wrote: > When building QEMU for NetBSD ("make vm-build-netbsd"), the compiler > complains: > > In file included from /usr/include/ctype.h:100, > from ../src/include/qemu/osdep.h:123, > from ../src/util/cutils.c:25: > ../src/util/cutils.c: In function 'do_strtosz': > ../src/util/cutils.c:245:61: warning: array subscript has type 'char' [-Wchar-subscripts] > 245 | if (retval == 0 && *endptr == '.' && !isdigit(endptr[1])) { > > isdigit() should not be used with plain "char" variables since these > can be signed and isdigit() could be implemented as a macro that uses > its parameter to index into an array. Use our wrapper qemu_isdigit() > to fix this problem. > > Signed-off-by: Thomas Huth > --- > util/cutils.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|