From: Jan Maslak <jan.maslak@intel.com>
To: "Hajda, Andrzej" <andrzej.hajda@intel.com>
Cc: <igt-dev@lists.freedesktop.org>, <zbigniew.kempczynski@intel.com>
Subject: Re: [PATCH 1/1] lib/rendercopy: Use the Xe2+ depth buffer packet
Date: Thu, 10 Sep 2026 18:03:39 +0200 [thread overview]
Message-ID: <aqLU2yLfbzFD6p5U@ART-DEV-395> (raw)
In-Reply-To: <2999bd00-ef43-4f51-881b-81545e827a2d@intel.com>
On Thu, Sep 10, 2026 at 03:33:07PM +0200, Hajda, Andrzej wrote:
> Hmm, you have dropper 4tile check for xe2+, is it intentional?
> If yes, please document it somewhere (commit message).
Yes, this is intentional. Xe2+ platforms also have HAS_4TILE set, but they
require the eight-dword GFX20 depth-buffer packet rather than the ten-dword
GFX125 packet. Therefore, the generation check needs to take precedence.
The HAS_4TILE check remains unchanged for older platforms, where it
distinguishes the relevant Gen12 variants. I'll clarify this in the commit
message.
Regards
Jan
next prev parent reply other threads:[~2026-09-10 16:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-10 12:39 [PATCH 0/1] lib/rendercopy: Use the Xe2+ depth buffer packet Jan Maslak
2026-09-10 12:39 ` [PATCH 1/1] " Jan Maslak
2026-09-10 13:33 ` Hajda, Andrzej
2026-09-10 16:03 ` Jan Maslak [this message]
2026-09-10 16:22 ` ✓ Xe.CI.BAT: success for " Patchwork
2026-09-10 17:06 ` ✓ i915.CI.BAT: " Patchwork
2026-09-10 23:44 ` ✗ Xe.CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqLU2yLfbzFD6p5U@ART-DEV-395 \
--to=jan.maslak@intel.com \
--cc=andrzej.hajda@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=zbigniew.kempczynski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.