Re: [PATCH v2] man/man2: introduce man page for file_getattr/file_setattr syscalls

[Alejandro Colomar <alx@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1325 bytes --]

Hi Darrick,

> Date: 2026-09-10 09:44:28-0700
> From: "Darrick J. Wong" <djwong@kernel.org>
>
[...]
> > > > Should we document FS_IOC_FSGETXATTR in a new FS_IOC_FSGETXATTR(2const)
> > > > manual page?
> > > 
> > > https://www.man7.org/linux/man-pages/man2/ioctl_xfs_fssetxattr.2.html
> > 
> > Thanks!  I didn't know that page.
> > 
> > I see the page uses the constants as XFS_ instead of FS_?  I think the
> 
> The sorded history of the xfs(ish) file attributes calls is that they
> began their lives as XFS_IOC_FSGETXATTR since they were XFS-specific.
> Then we tried to make them "generic" by removing the 'X', and that's how
> we got FS_IOC_FSGETXATTR.  Finally Andrey came along and made them
> proper syscalls with path-lookup abilities ... but for now they use the
> same struct as the old XFS_IOC_FSGETXATTR.
> 
> Personally I think we should only document XFS_IOC_FSGETXATTR (in
> xfsprogs) and file_getattr (in man-pages).  And leave FS_IOC_FSGETXATTR
> unmentioned.
> 
[...]
> 
> quotactl (and xattrs) have a similar weird history of originating in XFS
> and later getting yanked into the vfs.  Every time I have to go look up
> the quota syscalls I just get a headache. :/

Thanks!  That makes sense.  :)


Cheers,
Alex

> 
> --D

-- 
<https://www.alejandro-colomar.es>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]