Re: [PATCH v2 1/2] erofs-utils: mkfs: defer compressed metadata generation

[Gao Xiang <xiang@kernel.org>]

Hi Yifan,

On Fri, Sep 11, 2026 at 04:35:37PM +0800, Yifan Zhao wrote:
> 
> On 11/9/26 11:59, Gao Xiang wrote:
> > Generally, unique addresses should be assigned after the size of
> > the primary device is decided.
> > 
> > Defer compressed metadata generation until after
> > erofs_update_all_devices().  This is used to support multi-device
> > compressed filesystems (including fsmerge support for compressed
> > images.)
> > 
> > Signed-off-by: Gao Xiang <xiang@kernel.org>
> > ---

...

> > +			++nexts;
> >   		}
> > -		++nexts;
> > +		inode->z_extents = nexts;
> Hi Xiang,
> 
> I think this line seems redundant as `z_extents` is not used with encoded
> extents disabled.

I've addressed most of your comments, except above.
Since it's no harm to leave a valid number here and it can be used
later if needed.

Thanks,
Gao Xiang