All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@oss.nxp.com>
To: Frieder Schrempf <frieder.schrempf@kontron.de>
Cc: Frieder Schrempf <frieder@fris.de>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Frank Li <Frank.Li@nxp.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Shawn Guo <shawnguo@kernel.org>,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Eberhard Stoll <eberhard.stoll@kontron.de>
Subject: Re: [PATCH 1/9] ARM: dts: imx6ul-kontron-bl-common: Replace UART3 with DIP switch GPIOs
Date: Fri, 11 Sep 2026 11:59:40 -0500	[thread overview]
Message-ID: <aqQzfBp1gzQccGWt@SMW015318> (raw)
In-Reply-To: <e3b4c69f-6bfd-4765-b3b1-abf0958b5446@kontron.de>

On Thu, Sep 10, 2026 at 09:05:14AM +0200, Frieder Schrempf wrote:
> On 09.09.26 20:45, Frank Li wrote:
> > On Tue, Sep 08, 2026 at 03:51:48PM +0200, Frieder Schrempf wrote:
> >> From: Eberhard Stoll <eberhard.stoll@kontron.de>
> >>
> >> The latest board revision has DIP switches and lacks UART3 instead.
> >> As the old revision has long been deprecated and not maintained
> >> anymore, drop the support and reflect the current state of the
> >> hardware. As the old revision hasn't been widely used, UART3 was
> >> only available through an obscure extension connector and we have
> >> carried this patch downstream for years, no users are expected to
> >> be affected by this change.
> >
> > Remove "we have carried this patch downstream for years".
>
> Ok.
>
> >
> >>
> >> Signed-off-by: Eberhard Stoll <eberhard.stoll@kontron.de>
> >> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
> >> ---
> >>  .../boot/dts/nxp/imx/imx6ul-kontron-bl-common.dtsi  | 21 +++++----------------
> >>  1 file changed, 5 insertions(+), 16 deletions(-)
> >>
> >> diff --git a/arch/arm/boot/dts/nxp/imx/imx6ul-kontron-bl-common.dtsi b/arch/arm/boot/dts/nxp/imx/imx6ul-kontron-bl-common.dtsi
> >> index f4c45e964daf..a71669bef7d4 100644
> >> --- a/arch/arm/boot/dts/nxp/imx/imx6ul-kontron-bl-common.dtsi
> >> +++ b/arch/arm/boot/dts/nxp/imx/imx6ul-kontron-bl-common.dtsi
> >> @@ -172,13 +172,6 @@ &uart2 {
> >>  	status = "okay";
> >>  };
> >>
> >> -&uart3 {
> >> -	pinctrl-names = "default";
> >> -	pinctrl-0 = <&pinctrl_uart3>;
> >> -	uart-has-rtscts;
> >> -	status = "okay";
> >> -};
> >> -
> >>  &uart4 {
> >>  	pinctrl-names = "default";
> >>  	pinctrl-0 = <&pinctrl_uart4>;
> >> @@ -283,6 +276,11 @@ MX6UL_PAD_SNVS_TAMPER5__GPIO5_IO05	0x1b0b0	/* DOUT1 */
> >>  			MX6UL_PAD_SNVS_TAMPER4__GPIO5_IO04	0x1b0b0	/* DIN1 */
> >>  			MX6UL_PAD_SNVS_TAMPER1__GPIO5_IO01	0x1b0b0	/* DOUT2 */
> >>  			MX6UL_PAD_SNVS_TAMPER0__GPIO5_IO00	0x1b0b0	/* DIN2 */
> >> +
> >> +			MX6UL_PAD_UART3_TX_DATA__GPIO1_IO24	0x1b0b0	/* CAN_ADR0 (DIP sw 1) */
> >> +			MX6UL_PAD_UART3_RX_DATA__GPIO1_IO25	0x1b0b0	/* CAN_ADR1 (DIP sw 2) */
> >> +			MX6UL_PAD_UART3_CTS_B__GPIO1_IO26	0x1b0b0	/* CAN_ADR2 (DIP sw 3) */
> >> +			MX6UL_PAD_UART3_RTS_B__GPIO1_IO27	0x1b0b0	/* CAN_ADR3 (DIP sw 4) */
> >
> > supposed header overlay or real user should set it. otherwise, the real
> > user set it will be failure because pin conflict.
>
> Sorry, I can't figure out what you are suggesting here.

Please forget it.  I mess up.

Frank
>
> >
> > Frank
> >>  		>;
> >>  	};
> >>
> >> @@ -334,15 +332,6 @@ MX6UL_PAD_NAND_DATA07__UART2_DCE_RTS	0x1b0b1
> >>  		>;
> >>  	};
> >>
> >> -	pinctrl_uart3: uart3grp {
> >> -		fsl,pins = <
> >> -			MX6UL_PAD_UART3_TX_DATA__UART3_DCE_TX	0x1b0b1
> >> -			MX6UL_PAD_UART3_RX_DATA__UART3_DCE_RX	0x1b0b1
> >> -			MX6UL_PAD_UART3_CTS_B__UART3_DCE_CTS	0x1b0b1
> >> -			MX6UL_PAD_UART3_RTS_B__UART3_DCE_RTS	0x1b0b1
> >> -		>;
> >> -	};
> >> -
> >>  	pinctrl_uart4: uart4grp {
> >>  		fsl,pins = <
> >>  			MX6UL_PAD_UART4_TX_DATA__UART4_DCE_TX	0x1b0b1
> >>
> >> --
> >> 2.55.0
> >>
> >>
>

  reply	other threads:[~2026-09-11 16:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-08 13:51 [PATCH 0/9] Misc Kontron i.MX DT improvements Frieder Schrempf
2026-09-08 13:51 ` [PATCH 1/9] ARM: dts: imx6ul-kontron-bl-common: Replace UART3 with DIP switch GPIOs Frieder Schrempf
2026-09-09 18:45   ` Frank Li
2026-09-10  7:05     ` Frieder Schrempf
2026-09-11 16:59       ` Frank Li [this message]
2026-09-08 13:51 ` [PATCH 2/9] ARM: dts: imx6ul-kontron-bl-common: Add GPIO labels Frieder Schrempf
2026-09-08 13:51 ` [PATCH 3/9] ARM: dts: imx6ul-kontron-bl-common: Fix USB OTG1 ID pin configuration Frieder Schrempf
2026-09-08 13:51 ` [PATCH 4/9] arm64: dts: imx93-kontron: Adjust GPIO4_IO29 usage Frieder Schrempf
2026-09-08 13:51 ` [PATCH 5/9] arm64: dts: imx93-kontron: Make USB-C connector "device-only" Frieder Schrempf
2026-09-08 13:51 ` [PATCH 6/9] arm64: dts: imx8mm-kontron: Describe the ethernet PHY LEDs Frieder Schrempf
2026-09-08 13:51 ` [PATCH 7/9] arm64: dts: imx8mm-kontron: Add GPIO labels and comments Frieder Schrempf
2026-09-08 13:51 ` [PATCH 8/9] arm64: dts: imx8mm-kontron: Add SPI EERAM on BL device Frieder Schrempf
2026-09-09 19:13   ` Frank Li
2026-09-08 13:51 ` [PATCH 9/9] arm64: dts: imx8mp-kontron: Fix LVDS clock frequency for DL device Frieder Schrempf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aqQzfBp1gzQccGWt@SMW015318 \
    --to=frank.li@oss.nxp.com \
    --cc=Frank.Li@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=eberhard.stoll@kontron.de \
    --cc=festevam@gmail.com \
    --cc=frieder.schrempf@kontron.de \
    --cc=frieder@fris.de \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.