From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: Tapio Reijonen <tapio.reijonen@vaisala.com>
Cc: Saravanan Sekar <sravanhome@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] regulator: Add MPS MPQ4210 buck-boost regulator driver
Date: Fri, 11 Sep 2026 20:48:28 +0200 [thread overview]
Message-ID: <aqRMb8q7BT3uZ9iF@monoceros> (raw)
In-Reply-To: <20260910-mpq4210-regulator-v1-2-d37e208dfc8d@vaisala.com>
[-- Attachment #1: Type: text/plain, Size: 439 bytes --]
Hello,
On Thu, Sep 10, 2026 at 08:51:42AM +0000, Tapio Reijonen wrote:
> +#include <linux/i2c.h>
> [...]
> +#include <linux/mod_devicetable.h>
Please don't add new includes for <linux/mod_devicetable.h>, this header
is supposed to go away. For i2c_device_id and of_device_id you can rely
on <linux/i2c.h> to provide both. If you want to go full iwyu use
<linux/device-id/i2c.h> and <linux/device-id/of.h> respectively.
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-09-11 18:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-10 8:51 [PATCH 0/2] regulator: Add MPS MPQ4210 buck-boost regulator support Tapio Reijonen
2026-09-10 8:51 ` [PATCH 1/2] regulator: dt-bindings: Add MPS MPQ4210 Tapio Reijonen
2026-09-10 9:01 ` sashiko-bot
2026-09-11 8:45 ` Krzysztof Kozlowski
2026-09-10 8:51 ` [PATCH 2/2] regulator: Add MPS MPQ4210 buck-boost regulator driver Tapio Reijonen
2026-09-11 18:48 ` Uwe Kleine-König [this message]
2026-09-10 15:58 ` [PATCH 0/2] regulator: Add MPS MPQ4210 buck-boost regulator support Mark Brown
2026-09-10 15:58 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqRMb8q7BT3uZ9iF@monoceros \
--to=u.kleine-koenig@baylibre.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sravanhome@gmail.com \
--cc=tapio.reijonen@vaisala.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.