From: Dan Carpenter <error27@gmail.com>
To: Matthew Zvolsky <matthew-kernel@post.cz>
Cc: gregkh@linuxfoundation.org, vaibhav.sr@gmail.com,
mgreer@animalcreek.com, johan@kernel.org, elder@kernel.org,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: add missing newlines to sysfs_emit
Date: Fri, 11 Sep 2026 22:36:22 +0300 [thread overview]
Message-ID: <aqRYNjOCTRBIZtcG@stanley.mountain> (raw)
In-Reply-To: <20260911190253.894650-1-matthew-kernel@post.cz>
On Fri, Sep 11, 2026 at 09:02:53PM +0200, Matthew Zvolsky wrote:
> Add terminating newlines to sysfs_emit format strings to conform with
> kernel sysfs guidelines. Also clean up envp array declaration to be
> static const char * const.
>
> Signed-off-by: Matthew Zvolsky <matthew-kernel@post.cz>
> ---
This has been discussed before. Do a search for the function
names on lore.kernel.org.
regards,
dan carpenter
next prev parent reply other threads:[~2026-09-11 19:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 19:02 [PATCH] staging: greybus: add missing newlines to sysfs_emit Matthew Zvolsky
2026-09-11 19:36 ` Dan Carpenter [this message]
2026-09-12 7:10 ` kernel test robot
2026-09-12 7:51 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqRYNjOCTRBIZtcG@stanley.mountain \
--to=error27@gmail.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=matthew-kernel@post.cz \
--cc=mgreer@animalcreek.com \
--cc=vaibhav.sr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.