From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
To: David Collin <davidcollin899@gmail.com>
Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] usb: dwc3: host: fix props[] overflow when all quirks are enabled
Date: Fri, 11 Sep 2026 23:12:42 +0000 [thread overview]
Message-ID: <aqSK2FNxv-jfDmd0@vbox> (raw)
In-Reply-To: <20260905164448.209348-2-davidcollin899@gmail.com>
On Sat, Sep 05, 2026, David Collin wrote:
> props[] is sized for exactly the number of properties
> dwc3_host_init() can populate, leaving no slot for the NULL
> terminator property_entries_dup() requires when usb3_lpm_capable,
> usb2_lpm_disable, and the <=3.00a PED quirk are all true. Size
> props[] for one more slot.
>
> Fixes: 8da7644493b4 ("usb: dwc3: Specify maximum number of XHCI interrupters")
> Cc: stable@vger.kernel.org
> Signed-off-by: David Collin <davidcollin899@gmail.com>
> ---
> drivers/usb/dwc3/host.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c
> index 74117cbb2f42..cd1e5204ac3a 100644
> --- a/drivers/usb/dwc3/host.c
> +++ b/drivers/usb/dwc3/host.c
> @@ -130,7 +130,7 @@ static int dwc3_host_get_irq(struct dwc3 *dwc)
>
> int dwc3_host_init(struct dwc3 *dwc)
> {
> - struct property_entry props[6];
> + struct property_entry props[7];
> struct platform_device *xhci;
> int ret, irq;
> int prop_idx = 0;
> --
> 2.55.0
>
Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Thanks,
Thinh
next prev parent reply other threads:[~2026-09-11 23:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 14:02 [PATCH] usb: dwc3: host: fix props[] overflow and dangling xhci pointer on error David Collin
2026-09-04 23:39 ` Thinh Nguyen
2026-09-05 16:44 ` [PATCH v2 1/2] usb: dwc3: host: fix dangling xhci pointer on init failure David Collin
2026-09-05 16:44 ` [PATCH v2 2/2] usb: dwc3: host: fix props[] overflow when all quirks are enabled David Collin
2026-09-11 23:12 ` Thinh Nguyen [this message]
2026-09-11 23:12 ` [PATCH v2 1/2] usb: dwc3: host: fix dangling xhci pointer on init failure Thinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqSK2FNxv-jfDmd0@vbox \
--to=thinh.nguyen@synopsys.com \
--cc=davidcollin899@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.