From: "Adrián Larumbe" <adrian.larumbe@collabora.com>
To: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Cc: Boris Brezillon <boris.brezillon@collabora.com>,
Rob Herring <robh@kernel.org>,
Steven Price <steven.price@arm.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>,
Simona Vetter <simona@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
kernel@collabora.com
Subject: Re: [PATCH] drm/panfrost: Rename "panthor" prefixes in debugfs identifiers
Date: Sat, 12 Sep 2026 00:38:56 +0100 [thread overview]
Message-ID: <aqSP2d1at9937MIc@sobremesa> (raw)
In-Reply-To: <20260901-panfrost-prefix-whoopsie-v1-1-138fb4c5a9f4@collabora.com>
Hi Nicolas, thanks for the patch.
I was wondering whether it makes sense to apply it in light of changes
in a patch series I've been working on for quite some time. One of the
patches moves all debugfs plumbing away from panfrost_drv.c and into
their relevant subsystems, and as part of that change I've renamed all
erroneous panthor_* prefixes into panfrost.
However, if the right policy in this case is to have them both committed
separately, then I'll be applying this one first.
Check https://lore.kernel.org/r/20260912-claude-fixes-v9-0-e588feaa61ef@collabora.com
patch 3/16 for further context.
Reviewed-by: Adrián Larumbe <adrian.larumbe@collabora.com>
On 01.09.2026 15:39, Nicolas Frattaroli wrote:
> When gems debugfs support was copied over from panthor to panfrost, the
> function and struct names were not adjusted to carry the panfrost
> prefix instead of the panthor prefix.
>
> Rectify this by renaming them. No functional change.
>
> Fixes: e48ade5e23ba ("drm/panfrost: show device-wide list of DRM GEM objects over DebugFS")
> Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
> ---
> drivers/gpu/drm/panfrost/panfrost_drv.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c
> index 96a66d673ba6..f5f11ad5f9b3 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_drv.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c
> @@ -794,7 +794,7 @@ static const struct file_operations panfrost_drm_driver_fops = {
> };
>
> #ifdef CONFIG_DEBUG_FS
> -static int panthor_gems_show(struct seq_file *m, void *data)
> +static int panfrost_gems_show(struct seq_file *m, void *data)
> {
> struct drm_info_node *node = m->private;
> struct panfrost_device *pfdev = to_panfrost_device(node->minor->dev);
> @@ -845,15 +845,15 @@ static int show_file_jm_ctxs(struct panfrost_file_priv *pfile,
> return 0;
> }
>
> -static struct drm_info_list panthor_debugfs_list[] = {
> +static struct drm_info_list panfrost_debugfs_list[] = {
> {"gems",
> - panthor_gems_show, 0, NULL},
> + panfrost_gems_show, 0, NULL},
> };
>
> -static int panthor_gems_debugfs_init(struct drm_minor *minor)
> +static int panfrost_gems_debugfs_init(struct drm_minor *minor)
> {
> - drm_debugfs_create_files(panthor_debugfs_list,
> - ARRAY_SIZE(panthor_debugfs_list),
> + drm_debugfs_create_files(panfrost_debugfs_list,
> + ARRAY_SIZE(panfrost_debugfs_list),
> minor->debugfs_root, minor);
>
> return 0;
> @@ -915,7 +915,7 @@ static void panfrost_sched_debugfs_init(struct drm_minor *minor)
>
> static void panfrost_debugfs_init(struct drm_minor *minor)
> {
> - panthor_gems_debugfs_init(minor);
> + panfrost_gems_debugfs_init(minor);
> panfrost_sched_debugfs_init(minor);
> }
> #endif
>
> ---
> base-commit: 0116f19db5931348c937eafa1f76a9a19bf82c81
> change-id: 20260901-panfrost-prefix-whoopsie-26300bf2dce9
>
> Best regards,
> --
> Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Adrian Larumbe
prev parent reply other threads:[~2026-09-11 23:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 13:39 [PATCH] drm/panfrost: Rename "panthor" prefixes in debugfs identifiers Nicolas Frattaroli
2026-09-02 6:58 ` Thomas Zimmermann
2026-09-11 23:38 ` Adrián Larumbe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqSP2d1at9937MIc@sobremesa \
--to=adrian.larumbe@collabora.com \
--cc=airlied@gmail.com \
--cc=boris.brezillon@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=nicolas.frattaroli@collabora.com \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=steven.price@arm.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.