From: Brian Masney <bmasney@redhat.com>
To: Rosen Penev <rosenp@gmail.com>
Cc: linux-clk@vger.kernel.org, "Stephen Boyd" <sboyd@kernel.org>,
"Brian Masney" <bmasney+clk@redhat.com>,
"Jerome Brunet" <jbrunet+clk@baylibre.com>,
"Andreas Färber" <afaerber@suse.de>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"moderated list:ARM/ACTIONS SEMI ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/ACTIONS SEMI ARCHITECTURE"
<linux-actions@lists.infradead.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] clk: actions: owl-pll: cast delay to unsigned long for uelay()
Date: Fri, 11 Sep 2026 20:02:28 -0400 [thread overview]
Message-ID: <aqSWlPP4YfAi15rE@redhat.com> (raw)
In-Reply-To: <20260904215013.98283-1-rosenp@gmail.com>
Hi Rosen,
The subject has a typo: s/uelay/udelay/
On Fri, Sep 04, 2026 at 02:50:13PM -0700, Rosen Penev wrote:
> The 'delay' field in struct owl_pll_hw is u8, but udelay() internally
> compares its argument against MAX_UDELAY_MS * 1000 (2000). Since a u8
> can never exceed 255, the compiler warns of a tautological comparison
> that is always false:
>
> drivers/clk/actions/owl-pll.c:189:2: error: result of comparison of
> constant 2000 with expression of type 'u8' is always false
>
> Cast the delay value to unsigned long to widen the type and silence the
> warning without changing behavior.
Just to clarify: This only shows up with a W=1 build, right? If so, it
would be good to clarify that in the commit message.
>
> Assisted-by: opencode:big-pickle
The new guidance is:
Assisted-by: LLM
Brian
prev parent reply other threads:[~2026-09-12 0:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 21:50 [PATCH] clk: actions: owl-pll: cast delay to unsigned long for uelay() Rosen Penev
2026-09-12 0:02 ` Brian Masney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqSWlPP4YfAi15rE@redhat.com \
--to=bmasney@redhat.com \
--cc=afaerber@suse.de \
--cc=bmasney+clk@redhat.com \
--cc=jbrunet+clk@baylibre.com \
--cc=linux-actions@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=rosenp@gmail.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.