Re: [PATCH 1/3] man/man5/proc_pid_smaps{,_rollup}.5: Add proc_pid_smaps_rollup(5)

[Alejandro Colomar <alx@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2274 bytes --]

Hi Max,

> Date: 2026-09-12 05:32:11-0600
> From: Max Chernoff <git@maxchernoff.ca>
>
> Document /proc/pid/smaps_rollup, which is similar to /proc/pid/smaps,
> except it merges all mappings are merged into a single synthetic
> entry [1].
> 
> Also, add a better description to the NAME, following the discussion
> in [2].

Thanks!  Although I'd prefer the renaming to happen in a separate
commit, please.

> Link [1]: <https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=493b0e9d945fa9dfe96be93ae41b4ca4b6fdb317>
> Link [2]: <https://lore.kernel.org/lkml/3f250c7105010613115554b9d9@mail.gmail.com>

Would you mind quoting the most relevant lines of it?  It seems a long
discussion.

> Signed-off-by: Max Chernoff <git@maxchernoff.ca>
> ---
>  man/man5/proc_pid_smaps.5        | 7 ++++++-
>  man/man5/proc_pid_smaps_rollup.5 | 1 +
>  2 files changed, 7 insertions(+), 1 deletion(-)
>  create mode 100644 man/man5/proc_pid_smaps_rollup.5
> 
> diff --git a/man/man5/proc_pid_smaps.5 b/man/man5/proc_pid_smaps.5
> index 9c433dbc1e60..51440cc13bf6 100644
> --- a/man/man5/proc_pid_smaps.5
> +++ b/man/man5/proc_pid_smaps.5
> @@ -7,7 +7,7 @@
>  .\"
>  .TH proc_pid_smaps 5 (date) "Linux man-pages (unreleased)"
>  .SH NAME
> -/proc/pid/smaps \- XXX: What does 's' in "smaps" stand for?
> +/proc/pid/smaps, /proc/pid/smaps_rollup \- size of mapped memory regions
>  .SH DESCRIPTION
>  .TP
>  .IR /proc/ pid /smaps " (since Linux 2.6.14)"
> @@ -125,5 +125,10 @@
>  file is present only if the
>  .B CONFIG_PROC_PAGE_MONITOR
>  kernel configuration option is enabled.
> +.TP
> +.IR /proc/ pid /smaps_rollup " (since Linux 4.14)"
> +This file is similar to
> +.IR /proc/ pid /smaps ,
> +except all mappings are merged into a single synthetic entry.

LGTM.  Thanks!


Have a lovely day!
Alex

>  .SH SEE ALSO
>  .BR proc (5)
> diff --git a/man/man5/proc_pid_smaps_rollup.5 b/man/man5/proc_pid_smaps_rollup.5
> new file mode 100644
> index 000000000000..4b5f9eba0484
> --- /dev/null
> +++ b/man/man5/proc_pid_smaps_rollup.5
> @@ -0,0 +1 @@
> +.so man5/proc_pid_smaps.5
> 
> base-commit: 59ba1c34fb6538206e96597739f053183d1e6428
> -- 
> 2.55.0
> 

-- 
<https://www.alejandro-colomar.es>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]