All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Alexander Shirokov <shirokovalexs@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/nnn: add BR2_TOOLCHAIN_HAS_THREADS dependency
Date: Sun, 20 Sep 2026 13:28:01 +0200	[thread overview]
Message-ID: <aq_C_jltc2dsvVi-@windsurf> (raw)
In-Reply-To: <20260919163604.897135-1-shirokovalexs@gmail.com>

Hello Alexander,

On Sat, Sep 19, 2026 at 06:35:56PM +0200, Alexander Shirokov wrote:
> nnn links against pthread. Specify the dependency to avoid
> unexpected build failures on toolchains lacking thread support (e.g.
> br-arm-full-nothread).
> 
> Signed-off-by: Alexander Shirokov <shirokovalexs@gmail.com>

Thanks for your updated patch. However, a patch fixing an issue must
indicate when the issue was introduced. Is it since package/nnn was
introduced? Due to a subsequent version bump of nnn?

Ideally, we like to have:

Fixes: <commithash> ("commit title")

This helps the maintainers of Buildroot LTS branches in figuring out
whether the patch needs to be backported or not.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2026-09-20 11:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-19 16:35 [Buildroot] [PATCH 1/1] package/nnn: add BR2_TOOLCHAIN_HAS_THREADS dependency Alexander Shirokov
2026-09-20 11:28 ` Thomas Petazzoni via buildroot [this message]
2026-09-22 13:18   ` [Buildroot] [v2 " Alexander Shirokov
2026-10-10 17:25     ` Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aq_C_jltc2dsvVi-@windsurf \
    --to=buildroot@buildroot.org \
    --cc=shirokovalexs@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.